[#2841] Relocated the installer into the 'drevops/vortex-cli' package. - #2856
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #2856 +/- ##
==========================================
+ Coverage 88.08% 88.11% +0.02%
==========================================
Files 98 98
Lines 5379 5392 +13
Branches 3 3
==========================================
+ Hits 4738 4751 +13
Misses 641 641 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Code coverage (threshold: 90%) Per-class coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2841
Summary
A standalone installer becomes the
installsubcommand of avortexCLI. Everything named after the installer - the directory, the package, the namespace, the binary, the PHAR, the environment variables, the on-screen copy, the demo video - is renamed to say so. The install flow itself is unchanged: the same prompts in the same order, the same derivations, the same processed files.Renames
.vortex/installer.vortex/clidrevops/vortex-installerdrevops/vortex-cliDrevOps\VortexInstaller\DrevOps\VortexCli\installer.phpvortexbuild/installer.phar.build/vortex.pharinstaller.phpvortex.phar/install,/v1/install,/v2/installvortex-test-installer.ymlvortex-test-cli.ymlInstallerPresenterInstallPresenterinstaller.*cli-install.*maintenance/installer.mdxmaintenance/cli.mdxEnvironment variables
Renamed by scope, with a backwards-compatible fallback. CLI-level variables move to
VORTEX_CLI_*(VERSION,URL,PATH,URL_CACHE_BUST). Install-command variables move toVORTEX_CLI_INSTALL_*(the 14Configconstants, thePROMPT_<ID>prefix,TEMPLATE_REPO,INTERACTIVE). The supersededVORTEX_INSTALLER_*names still resolve via an ordered prefix map inEnv::get()and invortex-update, and each legacy read emits a one-line deprecation notice naming its replacement. Existing consumer sites keep working.symfony/processis now declared explicitly incomposer.json- it was already used but only resolved transitively throughcomposer/composer.Version resolution
The version is resolved once, at the application level in the
vortexbinary, and every consumer reads it from there via$this->getApplication()->getVersion()- the install banner, the release-tag prefix, and the major-compatibility gate. Box substitutes@vortex-cli-version@when packaging the PHAR, so a version still carrying the placeholder means the CLI is running straight from source, and it resolves todevelopment.Two consequences of moving that resolution up from the install command's presenter:
vortex --versionand the install banner now agree in every context. Previously only the banner tidied the unsubstituted placeholder, so running from source printed a raw@vortex-cli-version@at the CLI level.Env::get(Config::VERSION, ...)rather than a rawgetenv(), soVORTEX_INSTALLER_VERSIONresolves through the same fallback as every other superseded name. A rawgetenv()would have silently dropped support for it.Deviation from the issue's acceptance criteria
The issue listed the
VORTEX_INSTALLER_*variable names and the output text as "Deliberately unchanged". Both were deliberately overridden after review, so the criterion "the same test and assertion counts as before the move" no longer holds literally. The gate applied instead: no existing test was removed or weakened; the only additions are the fallback and deprecation-notice coverage.Baseline was 1605 tests / 5158 assertions; final is 1617 tests / 5177 assertions. That is +12 tests, all covering the new fallback and deprecation notice. Assertions are +19 rather than +20 because one presenter test was rewritten to match the moved version resolution: it asserted that the presenter substituted the placeholder, which is no longer the presenter's job, so it now makes a single assertion that the version is rendered as given.
Reviewer notes
ahoy update-snapshotsregenerated all 143 scenarios with Updated: 0 - zero fixture changes, which is the issue's primary acceptance criterion. The two template files touched (.docker/cli.dockerfile,scripts/vortex-tooling.sh) are edited only inside#;< VORTEX_DEVfences that are stripped before fixtures are written..gitattributesexport-ignorewas renamed in the same commit as the directory move - this is what keeps the CLI's own source out of scaffolded projects.vortex-release.ymlandvortex-test-docs.ymlintentionally retain.vortex/installerpaths on their other-major (1.x) legs, because1.xstill ships the installer. Only the this-ref legs moved to.vortex/cli.release-installerbranch trigger was kept alongside a newrelease-clitrigger so existing pre-release branch names still work.Before / After