Use shutil.copy instead of os.system('cp ...') for CV output files#51
Open
rayair250-droid wants to merge 1 commit into
Open
Use shutil.copy instead of os.system('cp ...') for CV output files#51rayair250-droid wants to merge 1 commit into
rayair250-droid wants to merge 1 commit into
Conversation
…idate output The three output copies used os.system with f-string-interpolated paths, which breaks when the output path contains spaces or shell metacharacters, and is Unix-only. Replace with shutil.copy + os.path.join (shutil is already imported).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The train/subtrain/validate/test output files were copied with
os.systemand an f-string-interpolated path:This breaks when the output path (
iTrainOut, …) contains spaces or shell metacharacters, and is Unix-only. Replaced the four copies withshutil.copy+os.path.join(shutilis already imported), so they are shell-free, robust to special characters, and portable. Behavior is otherwise unchanged.