fix: avoid panic on undersized packets in Vortex::try_from#103
Merged
gaius-qi merged 1 commit intoJun 15, 2026
Merged
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
f9e5244 to
a38aa01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Guard
Vortex::try_frombeforesplit_to(HEADER_SIZE), so inputs shorter than 6 bytes returnInvalidPacketinstead of blowing up.Also adds a regression test for a 3 byte packet. tiny fix, but a real footgun.
Related Issue
Closes #102
Motivation and Context
This is triggerable in practice.
Read::readcan return fewer bytes than requested, so partial or truncated buffers are normal enough.Repro on
main:Before this patch it panics in
BytesMut::split_to. After this patch it returnsinvalid vortex packet. pretty straight forward.Screenshots (if appropriate)
n/a