Skip to content

feat(entra): datastore entra integration - #576

Merged
tjovicic merged 1 commit into
mainfrom
tjovicic/datastores-entra-integration
Oct 19, 2026
Merged

tjovicic merged 1 commit into
mainfrom
tjovicic/datastores-entra-integration

Conversation

@tjovicic

Copy link
Copy Markdown
Contributor

Explaining how to connect to a datastore using EntraID

Explaining how to connect to a datastore using EntraID
Copilot AI balanced review requested due to automatic review settings October 19, 2026 10:32
@vercel

vercel Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
documentation Ready Ready Preview Oct 19, 2026 10:33am UTC

Request Review

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can import rules and skills only from the repositories your team follows

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Document Microsoft Entra ID data store connections

📝 Documentation 🕐 10-20 Minutes

Grey Divider

AI Description

• Consolidate Entra ID setup guidance into the data store documentation for a complete connection
 workflow.
• Explain identity-based ACL rules and token authentication with Azure CLI and Redis CLI.
• Remove the obsolete identity-provider page and its category listing.
Diagram

graph TD
  A["Azure app"] --> B["Identity provider"] --> C["Entra data store"] --> D["OID ACL rule"] --> F["Redis CLI connection"]
  A --> E["Scoped access token"] --> F
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Dedicated Entra data store guide
  • ➕ Easier to find as a standalone guide
  • ➕ Leaves the general data store page shorter
  • ➖ Splits setup from the data store instructions it depends on
  • ➖ Requires cross-links to keep the workflow connected

Recommendation: Keep the integrated walkthrough for now: Azure registration, store authorization, and connection form one short workflow. Consider a dedicated guide if additional Entra authentication scenarios make this section substantially longer.

Files changed (2) +58 / -1

Documentation (2) +58 / -1
_category_.ymlRemove identity providers from the access category summary +1/-1

Remove identity providers from the access category summary

• Removes identity providers from the generated category description after the standalone page is deleted.

docs/cloud/access-permissions/category.yml

datastores.mdAdd an end-to-end Entra ID data store guide +57/-0

Add an end-to-end Entra ID data store guide

• Moves Azure application and Dragonfly Cloud identity-provider setup into the data store page. Adds instructions for selecting Entra ID, authorizing an object ID with an ACL rule, and connecting over TLS using an Azure CLI token.

docs/cloud/datastores.md

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The user-token connection example omits delegated-scope and Azure CLI authorization prerequisites.

1 open issue
What changed in this PR

Consolidates Microsoft Entra ID integration guidance into the Dragonfly Cloud datastore documentation.

Changes:

  • Moves Azure and identity-provider setup into the datastore guide.
  • Adds ACL configuration and token-based connection instructions.
  • Updates the Access & Permissions category description.
File Description
docs/​cloud/​datastores.md Adds Entra setup, ACL, and connection guidance.
docs/​cloud/​access-permissions/​identity-providers.md Removes the standalone guide.
docs/​cloud/​access-permissions/​_category_.yml Removes identity providers from the category description.

Review effort: Balanced

Comment thread docs/cloud/datastores.md
2. Enter a descriptive **Name** and set **Supported account types** to **Accounts in this organizational directory only (Single tenant)**.
Click **Register**.
3. Navigate to **Expose an API** in the application's left sidebar and enable the **Application ID URI**.
Keep the default URI assigned by Azure. Copy and store this value to use when setting the scope of your token.

@moredure moredure left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tjovicic
tjovicic merged commit 08d0479 into main Oct 19, 2026
4 checks passed
@tjovicic
tjovicic deleted the tjovicic/datastores-entra-integration branch October 19, 2026 13:20

This branch was successfully deployed

1 active deployment
Preview — cdf90242 Deployed Oct 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants