Repository navigation
Replace badssl HTTP certificate tests with loopback servers - #135618
Merged
Merged
Conversation
Generate certificates for expired, self-signed, and hostname-mismatch scenarios and use scoped trust and local revocation checks for SocketsHttpHandler. Preserve the external native WinHTTP revocation cases. Dispose provisional TLS streams after failed authentication and add a cleanup regression test. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 63463cf1-4bfe-42e3-ad96-49f35e245dd1
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
MihaZupan
approved these changes
Oct 12, 2026
This was referenced Oct 12, 2026
…st.AcceptAllCerts.cs Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
This was referenced Oct 12, 2026
MihaZupan
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP certificate validation tests currently depend on public badssl.com endpoints, making their results sensitive to external availability and certificate configuration. Replace the applicable cases with loopback servers and certificates generated by the existing test helpers.
X509ChainPolicycustom trust to isolate SocketsHttpHandler validation errors, and the existing local PKI/revocation responder to exercise both revocation settings without installing trusted roots.The two external, no-callback WinHTTP revocation tests are intentionally retained. WinHttpHandler cannot use scoped custom trust, and callback-enabled replacements would test managed chain validation rather than native WinHTTP revocation enforcement.
Validation
Windows x64, using the
X:subst path:build.cmd clr+libs -rc release: passed.net11.0-windows: 44 passed, none skipped.net481: 11 passed, none skipped.Linux, macOS, mobile, and the retained external WinHTTP revocation cases were not run. No product code or public API changes.
Note
This pull request description was generated by GitHub Copilot.