Closed
Clarify chained configuration TryGet semantics and apply review-thread fixes#131577
Conversation
|
Azure Pipelines: 16 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Co-authored-by: rosebyte <14963300+rosebyte@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Clarify chained configuration TryGet semantics and apply review-thread fixes
Jul 30, 2026
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main PR
Description
This updates only the code requested in review thread
#pullrequestreview-4799878306: clarifyChainedConfigurationProvider.TryGetsemantics and align tests with nullable contracts.Provider behavior + API docs
TryGetnow treats any non-nullvalue as present (including empty string).Tests aligned with contract
truefalseandnullTryGetoutusage is nullable (string?) to matchIConfigurationProvider.TryGet.Customer Impact
Without this change, chained configuration can incorrectly treat empty string as missing, allowing lower-priority values to win unexpectedly. API docs also remain ambiguous for consumers interpreting
TryGet.Regression
This is a behavioral correctness fix for chained provider precedence with empty-string values;
nullremains treated as absence.Testing
Targeted unit tests were added for
TryGetempty-string and missing-key behavior, matching the intended nullable contract.Risk
Low. The functional change is a single-condition update in
TryGet, with scoped tests covering the affected behavior.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.