Fix foreground shutdown test - #131437
Open
eduardo-vp wants to merge 1 commit into
Open
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @VSadov |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates a CoreCLR regression test under src/tests to avoid relying on the xUnit wrapper-generated entrypoint, so the test’s exit-code behavior is driven solely by the test’s own Main/foreground thread logic (reducing race-induced flakiness under stress).
Changes:
- Disable the xUnit wrapper generator for the test project and remove the
TestLibraryproject reference. - Replace the xUnit
[Fact]entrypoint with a customMainmethod. - Increase the worker thread delay to widen the window for validating shutdown/exit-code behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tests/baseservices/threading/regressions/2164/foreground-shutdown.csproj | Disables wrapper generation and removes TestLibrary reference to run as a custom-Main process-isolated test. |
| src/tests/baseservices/threading/regressions/2164/foreground-shutdown.cs | Switches to Main and adjusts the sleep interval before Environment.Exit(100) for more stable behavior. |
Member
Author
|
/azp list |
Member
Author
|
/azp run runtime-coreclr jitstressregs |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a race between the xunit wrapper and the foreground thread (which thread sets the exit code) which is easier to trigger under JIT stress. Adding one more second to
Thread.Sleepand removing the wrapper should be enough to make this test pass even with JIT stress I think.Fixes #131403.