Skip to content

[wasm] Don't import the Mono wasm props on the CoreCLR path #131420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maraf merged 2 commits into from
Jul 28, 2026
+7 −1
Merged

[wasm] Don't import the Mono wasm props on the CoreCLR path #131420

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da9a574
[wasm] Give the CoreCLR wasm SDK its own props
lewing Jul 27, 2026
84a7701
Drop the CoreCLR props file, conditioning the import is enough
lewing Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/mono/nuget/Microsoft.NET.Runtime.WebAssembly.Sdk/Sdk/Sdk.targets.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,13 @@
<WasmEmitSymbolMap Condition="'$(UsingMicrosoftNETSdkBlazorWebAssembly)' != 'true' and '$(UsingMicrosoftNETSdkWebAssembly)' != 'true' and '$(WasmEmitSymbolMap)' == '' and '$(RunAOTCompilation)' != 'true'">true</WasmEmitSymbolMap>
</PropertyGroup>

<Import Project="$(MSBuildThisFileDirectory)\BrowserWasmApp.props" />
<!-- Mono and CoreCLR each get their own set of targets. BrowserWasmApp.props (and the
WasmApp.Common.props it imports) is Mono-only: it seeds target lists such as
WasmNestedPublishAppDependsOn with targets defined in WasmApp.Common.targets, which the
CoreCLR path does not import. CoreCLR needs no props counterpart: RuntimeIdentifier comes
from the WebAssembly SDK, and TargetOS/TargetArchitecture are only consumed in-tree, where
eng/OSArch.props derives them from the RID. -->
<Import Project="$(MSBuildThisFileDirectory)\BrowserWasmApp.props" Condition="'$(UseMonoRuntime)' != 'false'" />
<Import Project="$(MSBuildThisFileDirectory)\BrowserWasmApp.targets" Condition="'$(UseMonoRuntime)' != 'false'" />
<Import Project="$(MSBuildThisFileDirectory)\BrowserWasmApp.CoreCLR.targets" Condition="'$(UseMonoRuntime)' == 'false'" />
</Project>