Open
[browser] Remove AssetEntry from dotnet.d.ts public API#131413
Conversation
Co-authored-by: maraf <10020471+maraf@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
maraf
July 27, 2026 10:25
View session
maraf
added
arch-wasm
maraf
changed the title
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
maraf
marked this pull request as ready for review
July 27, 2026 10:26
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
lewing
approved these changes
Jul 27, 2026
lewing
left a comment
lewing
left a comment
Member
There was a problem hiding this comment.
does this break any user facing contract?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AssetEntrywas exported indotnet.d.tsbut not referenced by any other public type, making it dead public API surface.Changes:
AssetEntryfrom imports and exports insrc/mono/browser/runtime/types/export-types.tsAssetEntryfrom imports and exports insrc/native/libs/Common/JavaScript/types/export-api.tsdotnet.d.tsfiles via rollupThe interface definition is retained in internal sources (
types/index.ts,types/public-api.ts) sinceAssetEntryInternal extends AssetEntrystill relies on it internally.Contributes to #118561