[release/11.0-preview7] Add contentEncoding: base64 to JSON schema for byte[], Memory, and ReadOnlyMemory - #131412
Open
Youssef1313 with Copilot wants to merge 1 commit into
Open
[release/11.0-preview7] Add contentEncoding: base64 to JSON schema for byte[], Memory, and ReadOnlyMemory#131412Youssef1313 with Copilot wants to merge 1 commit into
contentEncoding: base64 to JSON schema for byte[], Memory, and ReadOnlyMemory#131412Youssef1313 with Copilot wants to merge 1 commit into
Conversation
…yte[], Memory, and ReadOnlyMemory Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Youssef1313
July 27, 2026 10:17
View session
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-text-json |
Youssef1313
marked this pull request as ready for review
July 27, 2026 12:04
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Youssef1313
approved these changes
Jul 27, 2026
eiriktsarpalis
approved these changes
Jul 27, 2026
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main PR #130881
Description
JsonSchemaExporterwas omitting"contentEncoding": "base64"for byte-array types despite STJ serializing them as base64 strings. Per JSON Schema 2020-12 §8.3,contentEncodingmust be set when the string payload is encoded.JsonSchema.cs: AddedContentEncodingPropertyNameconstant andContentEncodingproperty; wired intoKeywordCountandToJsonNodeByteArrayConverter,MemoryByteConverter,ReadOnlyMemoryByteConverter:GetSchema()now returnsContentEncoding = "base64"JsonSchemaExporterTests.TestTypes.cs: Updated expected schemas forbyte[],Memory<byte>,ReadOnlyMemory<byte>Before / After:
Customer Impact
Consumers using
JsonSchemaExporterto generate schemas for types withbyte[],Memory<byte>, orReadOnlyMemory<byte>properties get incomplete schemas — validators and tooling that rely oncontentEncodingwill not correctly identify the base64 encoding constraint.Regression
No — this is a missing feature, not a regression.
Testing
All 387
JsonSchemaExportertests pass, including the updated expectations for the three affected types.Risk
Low. Changes are confined to three converters and the internal
JsonSchemaclass. No behavior change to serialization/deserialization; only affects schema generation output.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.