Fix GC ASPNet bnechmarks on Linux#5239
Merged
Merged
Conversation
When running those benchmarks on Linux, we need to use different profiles. This change adds a separate ASPNetBenchmarks-Linux.csv to use as a source when generating the suite.
janvorli
added
the
gc-infrastructure
Contributor
There was a problem hiding this comment.
Pull request overview
Updates GC Infrastructure’s ASP.NET benchmark suite generation to use a Linux-specific benchmark command/profile list when creating suites on Linux, to ensure ASP.NET benchmarks run with the correct profiles on that platform.
Changes:
- Select an OS-dependent source CSV when generating the ASP.NET benchmark suite.
- Add
ASPNetBenchmarks-Linux.csvcontaining Linux-specific scenario command lines/profiles.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure/Commands/RunCommand/CreateSuiteCommand.cs | Chooses which ASP.NET benchmarks CSV to copy into the generated suite based on the current OS. |
| src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure/Commands/RunCommand/BaseSuite/ASPNetBenchmarks-Linux.csv | Adds Linux-specific ASP.NET benchmark definitions (profiles/command lines). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mrsharm
previously approved these changes
Jun 10, 2026
mrsharm
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running those benchmarks on Linux, we need to use different profiles. This change adds a separate ASPNetBenchmarks-Linux.csv to use as a source when generating the suite.