Fix InvalidProgramException from Seq.collect over a struct seq materialised with List.ofSeq/Seq.toList/Seq.toArray - #20227
Open
T-Gro wants to merge 3 commits into
Open
Fix InvalidProgramException from Seq.collect over a struct seq materialised with List.ofSeq/Seq.toList/Seq.toArray#20227T-Gro wants to merge 3 commits into
T-Gro wants to merge 3 commits into
Conversation
…aterialised with List.ofSeq/Seq.toList/Seq.toArray (#20203) Two codegen defects in LowerComputedListOrArraySeqExpr only manifested when the inner sub-collection is a value type implementing seq<'T> (e.g. ImmutableArray<_>), since a struct is never implicitly upcast: 1. The arbitrary sub-collection was passed to ListCollector.AddMany/AddManyAndClose(seq<'T>) with no coercion, emitting invalid IL (value type where a ref IEnumerable is expected). Now coerced to the collector's seq<'T> element type (GenCoerce emits box; unbox.any for structs, nothing for reference upcasts). 2. SeqUsing/SeqForEach/SeqTryFinally built mkTryFinally with the original (possibly struct) body type as the try/finally result type instead of unit, so the optimizer emitted ldnull; stloc <struct> - invalid IL. Now uses g.unit_ty. Adds hermetic execution regression tests under optimizations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…nbox.any for #20203 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
Warning No PR link found in some release notes, please consider adding it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20203
The comprehension lowering fed a struct (value-type) sub-collection straight into
ListCollector/ArrayCollector.AddMany, which expects a referenceseq<'T>, and typed the generatedtry/finallywith the original struct body type. That produced invalid IL — a value type where a referenceIEnumerablewas expected, plus a spuriousldnullstored into a struct local. The struct sub-collection is now coerced (boxed) toseq<'T>and thetry/finallyresult type isunit.