Remove the dead ImplicitYield language-feature flag - #20225
Open
T-Gro wants to merge 2 commits into
Open
Conversation
LanguageFeature.ImplicitYield is permanently enabled for every accepted langversion (min --langversion is 8.0), so the flag guard is always true. Keep only the enabled paths and delete the dead legacy branches: - CheckExpressionsOps.fs: collapse YieldFree to its enabled body and drop the now-dead cenv parameter from YieldFree, IsSimpleSemicolonSequenceElement, TryGetSimpleSemicolonSequenceOfComprehension and (|SimpleSemicolonSequence|_|). - CheckSequenceExpressions.fs: drop the constant conjunct in enableImplicitYield, delete the dead SynExpr.Paren guard arm, and delete the dead validateObjectSequenceOrRecordExpression block. - CheckArrayOrListComputedExpressions.fs: collapse the implicitYieldEnabled block and its nested match to the single reachable arm. - CheckComputationExpressions.fs: drop the constant conjunct in enableImplicitYield (field and its branches retained) and update the YieldFree call. The LanguageFeature.ImplicitYield definition is intentionally left in place; a later change removes it. No behavioural change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The LanguageFeature.ImplicitYield flag shipped in F# 4.7 and is permanently enabled (minimum accepted --langversion is 8.0), so it is dead configuration. All enforcement sites were already collapsed to the always-on path, leaving the flag unreferenced. Delete the ImplicitYield union case (both .fs and .fsi), its features-map entry, its GetFeatureString arm, and the featureImplicitYield resource string. The xlf localization files were regenerated via /t:UpdateXlf. The SynExpr.SequentialOrImplicitYield syntax node and related implementation are unaffected; only the feature flag is removed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev Caution No release notes found for the changed paths (see table below). Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format. The following format is recommended for this repository: `* . (PR #XXXXX)`
If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LanguageFeature.ImplicitYieldshipped in F# 4.7 and is permanently enabled for every accepted--langversion(the minimum accepted version is 8.0), so its guards were always true. The dead legacy branches behind the flag are collapsed to the always-on path and the flag itself is removed. No behavioural change.