Remove always-on OpenTypeDeclaration language feature flag - #20215
Open
T-Gro wants to merge 3 commits into
Open
Conversation
…l parameter The LanguageFeature.OpenTypeDeclaration flag is always-on for every supported --langversion (minimum 8.0, feature shipped in 5.0), so the gated branch is dead. Remove the flag checks at both enforcement sites and drop the now-unused mOpenDecl plumbing from TcOpenTypeDecl and TcOpenDecl and their call sites. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Delete the always-on LanguageFeature.OpenTypeDeclaration DU case, its features-map entry, GetFeatureString arm, and the featureOpenTypeDeclaration FSComp.txt string. Regenerate xlf localization files via UpdateXlf. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
AI-Tooling-Check-Scanned-Clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20148
OpenTypeDeclarationhas shipped since F# 5.0 and is enabled for every selectable--langversion(the minimum accepted is 8.0), so its flag could never be turned off. The flag and thecheckLanguageFeatureAndRecoverguard onopen typedeclarations are removed;--disableLanguageFeature:OpenTypeDeclarationis no longer a recognized feature name.