Clarify ToString return value when input is null#12676
Merged
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ECMA XML documentation for System.Convert.ToString overloads, aiming to clarify what gets returned when the input is null (per #12675), and it also normalizes markdown whitespace in multiple <remarks> sections.
Changes:
- Updates the
<returns>text forConvert.ToString(object, IFormatProvider)to remove the (incorrect) claim that it returnsnullwhenvalueisnull. - Adjusts parameter/returns docs for
Convert.ToString(object)andConvert.ToString(object, IFormatProvider)(currently introducing misleading wording around thenullcase). - Cleans up markdown whitespace/blank lines in many
ToStringoverload remarks blocks.
gewarren
commented
May 29, 2026
Removed duplicate sentence in Remarks section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Hide whitespace changes.)
Fixes #12675.