Surface SignalR Java WebSocket handshake HTTP errors - #68611
Open
HengYpinn wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for your PR, @HengYpinn. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
HengYpinn
marked this pull request as ready for review
August 18, 2026 06:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When negotiation is skipped, OkHttp reports a failed WebSocket upgrade through
onFailureand includes the HTTP response. The Java client was discarding that response, so callers only saw a generic exception and couldn't handle status codes such as 401.This surfaces non-101 handshake responses as the existing
HttpRequestException, including the status code, while keeping the original OkHttp failure as the cause. Failures without an HTTP response keep their current behavior.I added a regression test that serves a 401 response over a local socket and verifies the status code is available to callers.
Tested with
./gradlew spotlessCheck :test:test --no-daemon.Fixes #47597