Fix TryServeFromCacheAsync_ReturnsFalse_IfVaryByKeyContainsDelimiters failure - #68554
Open
Youssef1313 wants to merge 1 commit into
Open
Fix TryServeFromCacheAsync_ReturnsFalse_IfVaryByKeyContainsDelimiters failure#68554Youssef1313 wants to merge 1 commit into
Youssef1313 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates a ResponseCaching middleware test to use a base cache key that matches the ResponseCachingKeyProvider.CreateBaseKey format, ensuring the test exercises the intended “vary-by key contains delimiters” validation path.
Changes:
- Adjusted the pre-seeded
baseKeyinTryServeFromCacheAsync_ReturnsFalse_IfVaryByKeyContainsDelimitersto include the correct number of key delimiters.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Youssef1313
enabled auto-merge (squash)
August 15, 2026 09:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.