Derive Helix tool versions from dotnet-tools.json - #68499
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes duplicated dotnet-tool version properties by deriving Helix tool nupkg paths directly from .config/dotnet-tools.json, making Helix correlation payload contents automatically follow tool-manifest updates.
Changes:
- Removed
DotnetDumpVersionandDotnetServeVersionfromeng/Versions.props. - Added a new MSBuild task (
ResolveDotnetToolPackagePaths) to resolve tool nupkg paths from the dotnet tool manifest. - Updated
eng/helix/helix.projto include the resolved tool nupkgs in the Helix correlation payload and warn when expected nupkgs are missing.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/Versions.props | Removes duplicate dotnet tool version properties now sourced from the tool manifest. |
| eng/tools/RepoTasks/ResolveDotnetToolPackagePaths.cs | Introduces an MSBuild task to map tool IDs in dotnet-tools.json to expected global-packages nupkg paths. |
| eng/tools/RepoTasks/RepoTasks.tasks | Registers the new RepoTasks MSBuild task for use in build/Helix targets. |
| eng/helix/helix.proj | Switches Helix correlation payload tool inclusion to resolved paths from the tool manifest. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
.config/dotnet-tools.jsonas the source of truth for the tool nupkg paths included in the Helix correlation payload.This removes the duplicate
DotnetDumpVersionandDotnetServeVersionproperties fromeng/Versions.props, so Maestro tool-manifest updates such as #68489 do not require manually synchronizing those properties.DotnetEfVersionremains because the project template infrastructure also consumes it.