Skip to content

Obsolete Bootstrap 4 Identity UI support - #68477

Open
Youssef1313 with Copilot wants to merge 5 commits into
mainfrom
copilot/obsolete-bootstrap-4-support
Open

Obsolete Bootstrap 4 Identity UI support#68477
Youssef1313 with Copilot wants to merge 5 commits into
mainfrom
copilot/obsolete-bootstrap-4-support

Conversation

Copilot AI commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Obsolete Bootstrap 4 Identity UI support

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Warn when the default Identity UI selects obsolete Bootstrap 4.

Description

Change

  • Adds an MSBuild warning when IdentityUIFrameworkVersion is Bootstrap4.
  • Leaves Bootstrap 5 selection unchanged.
<IdentityUIFrameworkVersion>Bootstrap4</IdentityUIFrameworkVersion>

Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
Copilot AI changed the title [WIP] Obsolete Bootstrap 4 support in Identity UI package Obsolete Bootstrap 4 Identity UI support Aug 13, 2026
Copilot AI requested a review from Youssef1313 August 13, 2026 12:28

@Youssef1313 Youssef1313 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Create a property to disable this warning, and use that property to disable the warning in IdentitySample.DefaultUI.csproj

Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>

Copilot AI commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Create a property to disable this warning, and use that property to disable the warning in IdentitySample.DefaultUI.csproj

Implemented in 090ee1f. SuppressBootstrap4IdentityUIWarning disables the warning, and IdentitySample.DefaultUI now sets it to true.

@Youssef1313
Youssef1313 marked this pull request as ready for review August 14, 2026 05:39
Copilot AI lite review requested due to automatic review settings August 14, 2026 05:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a build-time MSBuild warning when a consuming project selects the Bootstrap 4 Identity UI framework version, signaling that Bootstrap 4 support is obsolete and will be removed in a future release, while keeping Bootstrap 5 as the default.

Changes:

  • Introduces an MSBuild target that emits a warning when IdentityUIFrameworkVersion resolves to Bootstrap4 (with an opt-out property).
  • Suppresses the new warning in the Identity Default UI test asset project that intentionally uses Bootstrap 4.
  • Suppresses the new warning in the Identity Default UI sample project that intentionally uses Bootstrap 4.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/Identity/UI/src/StaticWebAssets.Groups.targets Adds an MSBuild warning target when Bootstrap 4 is selected for Identity UI.
src/Identity/testassets/Identity.DefaultUI.WebSite/Identity.DefaultUI.WebSite.csproj Sets SuppressBootstrap4IdentityUIWarning to keep test asset builds warning-free while using Bootstrap 4.
src/Identity/samples/IdentitySample.DefaultUI/IdentitySample.DefaultUI.csproj Sets SuppressBootstrap4IdentityUIWarning to keep the sample build warning-free while using Bootstrap 4.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/Identity/UI/src/StaticWebAssets.Groups.targets Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider obsoleting Bootstrap 4 support in the default Identity UI package

3 participants