Qualify nested type references with their containing types#731
Merged
tannergooding merged 1 commit intoJul 13, 2026
Merged
Conversation
A reference to a nested type (e.g. A::Inner) was reduced to just its last name segment, so referencing it from another scope produced an unqualified name that doesn't resolve in C#. Walk the enclosing record decls and prefix them (A.Inner), while continuing to flatten namespaces as before. Fixes dotnet#579 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #579.
A reference to a nested type was reduced to only its last
::segment, so using it from another scope emitted an unqualified name that doesn't resolve:In
GetTypeName'sTagTypehandling, the::case didSplit(""::"").Last()and dropped all qualification. Nested types are emitted as nested C# types, so a reference needs the containing type(s) as a prefix. Walk the enclosingRecordDeclchain (mirroring the existing idiom inVisitIndirectFieldDecl) and prepend each remapped name, while still flattening namespaces (only record parents are added):Verified against the full matrix:
A::Inner->A.Inner(fields, params, return types, and the vtbl delegate signature)A::B::Inner->A.B.Inner(deep nesting)A::Color(enum nested in a struct) ->A.Colorns::Foo->Foo(namespaces still flattened)No existing golden output changed. Added
NestedTypeReferenceTest. Build0 warning / 0 error; full suite green.Note
This PR description and the code change were drafted by Copilot on my behalf.