Strip enum member type name from sibling references in initializers#730
Merged
tannergooding merged 1 commit intoJul 13, 2026
Merged
Conversation
When strip-enum-member-type-name is enabled, only the member declarations were stripped; references to sibling members inside an initializer expression kept the enum type prefix, producing code that referenced undefined names. Apply the same EscapeAndStripEnumMemberName transform to enum constant references so they match the stripped declarations. Fixes dotnet#576 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #576.
With
strip-enum-member-type-name, member declarations were stripped but references to sibling members inside an initializer kept the enum type prefix, so the output referenced undefined names:VisitDeclRefExprcomputed the reference name withEscapeNameand never applied the same stripping used when emitting the declaration (EscapeAndStripEnumMemberNameinVisitEnumConstantDecl). Apply that transform to enum constant references, keyed off the referenced member's own enum type name, so references match their declarations:EscapeAndStripEnumMemberNameis a no-op when the option is off, so non-strip output is byte-identical (verified: no golden changed). Anonymous enums are left untouched, and cross-enum references still resolve via the existingusing staticpath.Added
StripEnumMemberReferenceTest. Build0 warning / 0 error; full suite green.Note
This PR description and the code change were drafted by Copilot on my behalf.