Skip to content

Update Go version to 1.26 - #25

Open
donatj wants to merge 2 commits into
masterfrom
donatj-patch-1
Open

Update Go version to 1.26#25
donatj wants to merge 2 commits into
masterfrom
donatj-patch-1

Conversation

@donatj

@donatj donatj commented Jul 31, 2026

Copy link
Copy Markdown
Owner

Updated Go version from 1.24 to 1.26 in go.mod.

Updated Go version from 1.24 to 1.26 in go.mod.
Copilot AI review requested due to automatic review settings July 31, 2026 01:36
@donatj

donatj commented Jul 31, 2026

Copy link
Copy Markdown
Owner Author

@copilot run "go fix ./..." In the latest version of Go 1.26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Not ready to approve

The PR removes the toolchain pin (a behavior/reproducibility change) but the description only mentions updating the Go version, so it should be either restored/updated or explicitly justified.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

Updates the module’s declared Go version in go.mod to target Go 1.26.

Changes:

  • Bumped go directive from 1.24 to 1.26.
  • Removed the toolchain directive that previously pinned a specific Go toolchain version.
File summaries
File Description
go.mod Updates the module’s Go version declaration (and removes the pinned toolchain line).
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

Comment thread go.mod
Comment on lines 1 to 4
module github.com/donatj/sqlread

go 1.24

toolchain go1.24.4
go 1.26

Copilot AI commented Jul 31, 2026

Copy link
Copy Markdown

@copilot run "go fix ./..." In the latest version of Go 1.26

Done. go fix ./... was run and applied the following changes:

  • detail.go / parser.go: Replaced string concatenation (s += ...) with strings.Builder
  • scanner.go: Replaced manual byte-search loops with slices.Contains

All tests pass. Commit: run go fix ./... for Go 1.26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants