Repository navigation
feat(offload): add docker-offload-plugin deb/rpm packaging - #562
Open
nicksieger wants to merge 3 commits into
Open
nicksieger wants to merge 3 commits into
nicksieger wants to merge 3 commits into
Conversation
thaJeztah
reviewed
Nov 10, 2026
Comment on lines
+95
to
+96
| # Packages only the prebuilt linux binaries; darwin and windows ship through the source repo. | ||
| offload = ["linux/amd64", "linux/arm64"] |
Member
There was a problem hiding this comment.
I think ideally, we'd also publish static binaries through download.docker.com for the other platforms. While GitHub "works" to distribute binaries, it's not always ideal, and having a more "official" distribution channel through download.docker.com is good to have.
(we're in process of providing static binaries for all packages that we also provide deb / rpm packages for).
Member
Author
There was a problem hiding this comment.
I'd like to do this eventually, I have some tickets to follow up on mac and windows binaries, so will revisit in another PR.
nicksieger
force-pushed
the
offload-packaging
branch
from
November 11, 2026 19:59
4cbefba to
fb63f47
Compare
Add Linux packaging recipes for the docker-offload CLI plugin (pkg/offload) and wire the package into docker-bake.hcl: PKGS_BASE, PKG_PLATFORMS_BASE, PKG_DISTROS, a VERSION/OFFLOAD_BIN variable pair, and a _pkg-offload target. Packages prebuilt, signed docker-offload-linux-<arch> binaries rather than building from source, same deliberate exception as sbx. No PKG_REPO/PKG_REF defaults, since the Dockerfile never consumes those args (no git clone, no metadata stage). Signed-off-by: Nick Sieger <nick@nicksieger.com>
Compile the plugin in the package build (dh_auto_build, rpm %build) through the ce-release make target of the source tree, instead of packaging prebuilt binaries. - source tree passed in as the src named context, dependencies vendored; no git clone - VERSION (v prefix), COMMIT, BUILD, DATE bake variables passed to the make target - optional build-env file secret via PKG_BUILD_ENV_FILE - GO_VERSION pinned to the release toolchain (1.27.3) - strip overrides kept so the packaged binary matches the release binary - offload excluded from the nightly package list Signed-off-by: Nick Sieger <nick@nicksieger.com>
- debhelper-compat 13, as in docker#550 - debian 13 trixie defaults for the distro and Go image variant, as in docker#567 - xx 1.10.0 Signed-off-by: Nick Sieger <nick@nicksieger.com>
nicksieger
force-pushed
the
offload-packaging
branch
from
November 11, 2026 20:00
fb63f47 to
01bfdab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg/offload), for ubuntu2404, ubuntu2604 and rockylinux8 on linux/amd64 and linux/arm64.dh_auto_buildand the rpm%build, through thece-releasemake target of the source tree, aspkg/modeldoes.PKG_REPO/PKG_REFclone. The caller passes the vendored source tree as thesrcnamed context, and builds run from the source repo's own workflow. Offload is excluded from the nightly package list (.pkgs.yml).VERSION(withvprefix),COMMIT,BUILDandDATE, passed to the make target, andPKG_BUILD_ENV_FILE, which adds an optionalbuild-envfile secret to thepkgtarget. Packages that don't mount it are unaffected.GO_VERSIONis pinned to the release toolchain (1.27.3), and the strip overrides are kept, so the build is reproducible and the packaged binary matches the release binary.🤖 Generated with Claude Code