sbx: describe sbx kit add as a sandbox restart, not a container recreation#25546
Open
dvdksn wants to merge 3 commits into
Open
sbx: describe sbx kit add as a sandbox restart, not a container recreation#25546dvdksn wants to merge 3 commits into
sbx kit add as a sandbox restart, not a container recreation#25546dvdksn wants to merge 3 commits into
Conversation
…ation Reword the three kit-add descriptions in customize/kits.md to say sbx kit add restarts the sandbox to apply the kit, rather than recreating the sandbox "container". Sandboxes are described elsewhere in terms of the VM and stop/restart lifecycle, so "container" is off message and overemphasizes an implementation detail. VM-state preservation and immediate network-rule application are unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The three wording changes in content/manuals/ai/sandboxes/customize/kits.md — replacing "recreates the sandbox container" with "restarts the sandbox" — are clean and consistent. No style violations, no accuracy issues, no formatting problems introduced by this PR.
craig-osterhout
approved these changes
Jul 13, 2026
The `docker sandbox` Docker Desktop plugin was fully removed in Docker Desktop 4.80.0. Remove the dedicated docs page, all CLI reference YAML files, and update the retired products page to reflect removal rather than deprecation. Update the AI overview table to reference `sbx`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This reverts commit 4f351b1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #25533.
That PR described
sbx kit addas recreating the sandbox container.While technically true (the underlying mechanism swaps the container while
preserving VM state), "container" is off message for sandbox docs and
overemphasizes an implementation detail — sandboxes are described everywhere
else in terms of the VM and the stop/restart lifecycle (see
architecture.md: "You can stop and restart without recreating the VM,preserving installed packages and Docker images").
From a user's perspective,
sbx kit addforces a sandbox restart. Thisreword frames it that way in all three spots in
customize/kits.md:[!IMPORTANT]callout in the Using kits sectionsbx kit addusage example under the Local subsectionThe facts about VM-state preservation and immediate network-rule
application are unchanged.
Reviews
🤖 Generated with Claude Code