minor cleanups and fixes#569
Merged
Merged
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
No real impact, but `$cli_pkg_version` was used unconditionally, but was set conditionally. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Make sure both pkg_version and cli_pkg_version are only set on success to prevent them containing a bare "=", which we were stripping later on. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1 task
There was a problem hiding this comment.
Pull request overview
This PR makes small correctness/cleanup improvements to the install.sh installer, primarily around version pinning logic so that package version suffixes are only applied when a repository lookup succeeds.
Changes:
- Initialize
cli_pkg_versionalongsidepkg_versionto avoid unconditionally using an unset variable. - For APT installs, only prefix
=ontopkg_version/cli_pkg_versionafter a successful lookup, removing the need for later%=}stripping. - For YUM/DNF installs, ensure
pkg_versionis only derived/rewritten after validating the lookup succeeded, and move version-massaging closer to where it’s used.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vvoland
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix indentation
always declare cli_pkg_version
No real impact, but
$cli_pkg_versionwas used unconditionally,but was set conditionally.
move vars closer to where used
prevent bare "=" as version
Make sure both pkg_version and cli_pkg_version are only set on success
to prevent them containing a bare "=", which we were stripping later on.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)