Revert "ci: shorten the feedback loop (parallel jobs, warm Go cache, Build Cloud)" - #4223
Merged
Conversation
gtardif
approved these changes
Sep 10, 2026
aheritier
added a commit
that referenced
this pull request
Sep 10, 2026
Fork PRs receive neither repository variables nor an OIDC token, so the image job failed on `DOCKERHUB_OIDC_CONNECTION_ID must be configured` for the 60% of PRs that come from forks (the reason #4220 was reverted in #4223). The old condition compared the PR's *base* repository to this one, which is always true; trust is now decided on the *head* repository. Trusted runs keep Build Cloud and both platforms. Fork PRs build linux/amd64 on the runner with a plain docker-container builder, no login, nothing pushed, no build-record upload (the read-only token cannot create artifacts). The Dockerfile is exercised for every PR instead of being skipped.
aheritier
added a commit
that referenced
this pull request
Sep 10, 2026
…ally Fork PRs, PRs opened by Dependabot and other bots running with a read-only token, and CI in forks of this repo receive neither repository variables nor an OIDC token, so the image job failed on `DOCKERHUB_OIDC_CONNECTION_ID must be configured` (why #4220 was reverted in #4223). The old condition compared the PR's *base* repository to this one, which is always true. The job now decides at runtime: Build Cloud (both platforms, one runner) whenever the Hub OIDC connection id and the OIDC token endpoint are present, otherwise a plain docker-container builder on the runner, linux/amd64 only, nothing pushed, no build-record upload. Publishing runs still fail loudly when Build Cloud is unavailable rather than downgrading. The Dockerfile is exercised on every PR instead of being skipped or failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4220