feat(plan)!: remove the session_plan toolset - #4199
Open
trungutt wants to merge 1 commit into
Open
Conversation
Remove the per-session plan toolset (write_session_plan, read_session_plan, exit_plan_mode) and every session-plan tendril: - pkg/tools/builtin/sessionplan and its runtime-owned handlers - the session_plan_updated runtime event and its client decoder - the session scope in pkg/plans (Service.List no longer takes options, UpdateSession and UnsupportedError are gone) - session-plan rows in the TUI /plans browser and detail dialog - the --session/--scope flags on the plans CLI - the session_plan schema enum value, example, and docs The shared plan toolset, /plans browser, and plans CLI are unchanged for shared plans. Downstream consumers have migrated off the per-session workflow. BREAKING CHANGE: the session_plan toolset type is no longer accepted in agent configs.
aheritier
added
area/docs
trungutt
marked this pull request as ready for review
September 8, 2026 09:03
docker-agent
reviewed
Sep 8, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
🟢 No issues found — LGTM! View logs.
aheritier
added
the
kind/feat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
session_plantoolset existed to support a per-session "draft, review, execute" plan-mode workflow driven by a host application. Downstream consumers have retired that workflow and migrated off the toolset, leaving it with no remaining users — but with a wide footprint: runtime-owned tool handlers, a dedicated stream event, a session scope threaded through the host-facing plans service, read-only session rows in the TUI/plansbrowser, and--session/--scopeaddressing on the plans CLI.This PR removes the toolset and all of that surface in one pass, so the plans stack is shared-plans-only:
Compatibility notes
session_planis removed from the schema's toolset-type enum. Configs still using it fail validation — that is the breaking change, flagged in the commit.session_plan_updatedis no longer emitted. Clients ignore unknown event types, and no event with this type will ever arrive again, so older clients are unaffected.scoperemains in every document (always"shared"); theunsupportederror code disappears along with the only operation that produced it.The shared
plantoolset, its optimistic-locking semantics, and the/plansbrowser behaviour for shared plans are untouched.