Skip to content

docs: record client lifetimes in AGENTS.md and point at the contributing guide #4197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IsmaelMartinez wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: record client lifetimes in AGENTS.md and point at the contributing guide #4197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,21 @@ Keep comments short and to the point:

- Use tools to gather information rather than relying on assumptions
- Examine existing code before making changes
- Grep for existing plumbing before adding a mechanism, and before calling
something unavailable
- Validate all changes before considering tasks complete
- Ask clarifying questions only when truly necessary
- When possible, call independent tools concurrently — it's faster

### Client and Session Lifetimes

- Provider clients are built per team load: once per session in `serve api`,
once at startup in `serve a2a` and `serve mcp`
- Anything that must vary per conversation belongs in a request middleware,
not in client construction
- The session ID is on the request context via
`httpclient.SessionIDFromContext`; `chatgptAuthMiddleware` shows the shape

## Validation Requirements

Before marking work as complete:
Expand All @@ -48,6 +59,10 @@ Before marking work as complete:

# Development Commands

Canonical setup, commands and style guide:
[the contributing guide](docs/community/contributing/index.md). The list below
is a quick reference.

## Build and Development

- `task build` — Build the application binary (outputs to `./bin/docker-agent`)
Expand Down