Skip to content

fix(session): preserve the starred flag in AddSession #4182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kitadesign wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −16
Open

fix(session): preserve the starred flag in AddSession #4182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions pkg/session/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,29 +626,14 @@ func (s *SQLiteSessionStore) AddSession(ctx context.Context, session *Session) e
return ErrEmptyID
}

fields, err := sessionPersistedFieldsOf(session)
if err != nil {
return err
}

// Use a transaction to insert session and its items
tx, err := s.db.BeginTx(ctx, nil)
if err != nil {
return err
}
defer func() { _ = tx.Rollback() }()

_, err = tx.ExecContext(ctx,
`INSERT INTO sessions (
id, origin, tools_approved, safety_policy, input_tokens, output_tokens, title, cost, send_user_message,
max_iterations, working_dir, created_at, permissions, agent_model_overrides,
custom_models_used, thinking, parent_id, instruction_context, attributes
) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`,
session.ID, session.Origin, session.ToolsApproved, string(session.SafetyPolicy), session.InputTokens, session.OutputTokens, session.Title,
session.Cost, session.SendUserMessage, session.MaxIterations, session.WorkingDir,
session.CreatedAt.Format(time.RFC3339), fields.PermissionsJSON, fields.AgentModelOverridesJSON,
fields.CustomModelsUsedJSON, false, fields.ParentID, fields.InstructionContextJSON, fields.AttributesJSON)
if err != nil {
if err := s.addSessionTx(ctx, tx, session); err != nil {
return err
}

Expand Down
14 changes: 14 additions & 0 deletions pkg/session/store_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1220,3 +1220,17 @@ func TestAddSessionTerminationRoundTrip(t *testing.T) {
// Termination markers are not conversation messages.
assert.Len(t, retrieved.GetAllMessages(), 2)
}

func TestAddSession_PreservesStarred(t *testing.T) {
store, err := newSQLiteStoreForTest(t, filepath.Join(t.TempDir(), "sessions.db"))
require.NoError(t, err)
t.Cleanup(func() { require.NoError(t, store.Close()) })

sess := New(WithID("starred-session"))
sess.Starred = true
require.NoError(t, store.AddSession(t.Context(), sess))

loaded, err := store.GetSession(t.Context(), "starred-session")
require.NoError(t, err)
assert.True(t, loaded.Starred)
}
Loading