fix(#3996): keep image-output models eligible for session titles - #4021
Open
aheritier wants to merge 1 commit into
Open
fix(#3996): keep image-output models eligible for session titles#4021aheritier wants to merge 1 commit into
aheritier wants to merge 1 commit into
Conversation
aheritier
added
area/docs
aheritier
force-pushed
the
title-generation-model-filter
branch
from
August 24, 2026 15:13
5f99757 to
7934627
Compare
aheritier
force-pushed
the
title-generation-model-filter
branch
from
August 25, 2026 07:58
7934627 to
3a3ec50
Compare
aheritier
force-pushed
the
title-generation-model-filter
branch
from
August 25, 2026 20:24
3a3ec50 to
5e7dd33
Compare
aheritier
force-pushed
the
title-generation-model-filter
branch
from
August 26, 2026 11:07
5e7dd33 to
4fc5a8f
Compare
aheritier
force-pushed
the
title-generation-model-filter
branch
2 times, most recently
from
September 1, 2026 16:17
e77d359 to
4fc5a8f
Compare
aheritier
force-pushed
the
title-generation-model-filter
branch
from
September 1, 2026 16:29
4fc5a8f to
d5276db
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
aheritier
force-pushed
the
title-generation-model-filter
branch
from
September 6, 2026 16:14
d5276db to
91651fc
Compare
aheritier
force-pushed
the
title-generation-model-filter
branch
from
September 7, 2026 11:19
91651fc to
99cdd96
Compare
aheritier
force-pushed
the
title-generation-model-filter
branch
from
September 7, 2026 11:34
99cdd96 to
b7ed110
Compare
aheritier
force-pushed
the
title-generation-model-filter
branch
from
September 7, 2026 16:13
b7ed110 to
7ec2cad
Compare
aheritier
force-pushed
the
title-generation-model-filter
branch
from
September 7, 2026 16:47
7ec2cad to
e3b2104
Compare
aheritier
force-pushed
the
title-generation-model-filter
branch
from
September 8, 2026 06:17
e3b2104 to
409eaa9
Compare
aheritier
force-pushed
the
title-generation-model-filter
branch
from
September 8, 2026 07:57
409eaa9 to
6a062ae
Compare
aheritier
force-pushed
the
title-generation-model-filter
branch
from
September 8, 2026 17:31
6a062ae to
f0ac0eb
Compare
Add ordered title candidates: an explicit title_model override followed by the normal agent model, both with WithGeneratingTitle. If the override cannot be constructed, keep the default candidate instead of failing agent startup. Do not filter candidates on image-output capability; Gemini utility calls omit image response modalities and skip the ordinary guard. Allow sessiontitle.New to accept ordered candidates, skip nil entries and return nil when none remain. Update runtime, server and debug-title callers and cover candidate selection and fallback. This changes title selection, not general inference routing. Its model-reference edit still describes the historical image-output exclusion; the final reference corrects it.
aheritier
force-pushed
the
title-generation-model-filter
branch
from
September 8, 2026 20:33
f0ac0eb to
13afae4
Compare
aheritier
marked this pull request as ready for review
September 8, 2026 20:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Build ordered session-title candidates from
title_modeland the normal agent model. Keep image-output-capable candidates eligible, skip nil candidates, and fall through after an empty or failed candidate. This changes title selection only; it does not guarantee a provider returns a nonempty title.Part of #3996. Review this PR against its immediate parent, #4020, rather than the aggregate stack against
main.Commit inventory
Head:
13afae4a093aac86a4af104510eac01a9be1c70d; parent SHA:ac6390e97f8c0f8cb20f890ac59e555dccdcc0d2.13afae4a093aac86a4af104510eac01a9be1c70d— fix(Epic: Gemini image output with workspace deliverables and portable session copies #3996): keep image-output models eligible for session titlesValidation
Build, test compilation, owning-package tests and the named fixture passed at this PR head.
Exact deterministic fixture command:
Matched top-level tests:
pkg/runtime: 3;pkg/sessiontitle: 2.Deterministic scope: the named local fixture exercises this PR boundary with disposable configuration/stores and fake or loopback providers as applicable. Every listed package ran nonzero matching top-level tests.
Deferred/live scope: Live provider, remote CI, and platform execution are not claimed by this deterministic receipt. The final stack head passed build, lint, full tests, an uncached full suite, focused race tests and documentation checks in disposable environments. Remote CI is tracked by the checks below; no new paid-provider or active-database validation was run.