fix(build): don't fail bake progress when stdout is not a console - #14184
Open
locker95 wants to merge 1 commit into
Open
fix(build): don't fail bake progress when stdout is not a console#14184locker95 wants to merge 1 commit into
locker95 wants to merge 1 commit into
Conversation
docker#14090 hands the real stdout file to buildkit so Windows TTY progress works. that also passes a redirected stdout (`build >/dev/null`) into ConsoleFromFile, which errors with "provided file is not a console". only unwrap a terminal file, and fall back to plain progress otherwise. Fixes docker#14182 Signed-off-by: Dean Chen <862469039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#14090 unwraps the real stdout file so Windows TTY progress works. that also feeds a redirected stdout (
compose build >/dev/null) into ConsoleFromFile, which then dies withprovided file is not a console.only unwrap when stdout actually is a terminal, and fall back to plain progress otherwise.
Fixes #14182