chore: remove github.com/buger/goterm dependency - #14180
Open
thaJeztah wants to merge 1 commit into
Open
Conversation
Replace goterm's terminal size detection with golang.org/x/term, which provides the same functionality and is already an indirect dependency. Use the existing github.com/morikuni/aec dependency for clearing the current terminal line. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-agent
reviewed
Sep 4, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR cleanly removes the github.com/buger/goterm dependency by substituting:
golang.org/x/termfor terminal size detection (term.GetSize)github.com/morikuni/aecfor line erasure (aec.EraseLine(aec.EraseModes.Tail))
The replacement is functionally equivalent:
aec.EraseLine(aec.EraseModes.Tail)emits\033[Kwhich, combined with the explicit\r, produces the same\r\033[Ksequence asgoterm.RESET_LINE- The combined fallback to
80×24whenterm.GetSizefails is a reasonable policy (previously width and height were guarded independently, but both falling back was already the expected behaviour) - Division-by-zero in
extraLines()is guarded by thewidth <= 0check ingetTermSize() golang.org/x/termis correctly promoted from indirect to direct dependency ingo.mod
No bugs were introduced.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace goterm's terminal size detection with golang.org/x/term, which provides the same functionality and is already an indirect dependency.
Use the existing github.com/morikuni/aec dependency for clearing the current terminal line.
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did