Conversation
Signed-off-by: Alexandre Rodrigues <alexandre3ylf@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The advanced
--networksyntax lowercases the entire option, including network names, aliases, and driver option keys and values. For example,--network name=MyNetwork,alias=WebAppmakes container startup fail withnetwork mynetwork not foundeven whenMyNetworkexists. The short--network MyNetworksyntax preserves the name.Normalize only the outer option key and preserve the supplied values. Also remove the second lowercasing pass in
parseDriverOpt. Outer keys such asNAMEremain accepted. Extend the existing parser and container configuration tests to cover mixed-case values, and correct the existing sysctl expectation to preserveIFNAME.Validation:
golangci-lint v2.13.2 run ./opts/... ./cli/command/container/...passes.WebAppalias, and the container starts successfully. Driver option preservation is covered by the unit tests.Release notes (optional)