compose: don't treat hyphens in :? error messages as defaults - #7316
Open
TastyHeadphones wants to merge 1 commit into
Open
TastyHeadphones wants to merge 1 commit into
TastyHeadphones wants to merge 1 commit into
Conversation
hardDefault ran before requiredNonEmpty and matched any "-", so a
required-variable error message like "must be set - try again" was
parsed as ${VAR-default} and silently succeeded.
Fixes docker#7313
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
${VAR:?must be set - try again}was succeeding when VAR was unset, becausehardDefaultmatched the-inside the error message and treated it as${VAR-default}.Reordered the substitute funcs so
:?/?run before-, and madehardDefaultskip strings that already contain?. Added regression tests.Fixes #7313