vendor: github.com/moby/moby/api v1.55.0-rc.1, moby/client v0.5.0-rc.1#7051
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
⏱️ PR Review Timed Out — The review agent hit the 1800 s time limit before completing. This usually happens on large or complex diffs. You can re-trigger with |
1 task
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR vendors updated versions of github.com/moby/moby/api (v1.55.0-rc.1) and github.com/moby/moby/client (v0.5.0-rc.1), introducing the new ImageAttestations API.
No issues found. The new code is well-structured and follows existing conventions:
image_attestations.go: Correctly uses the establisheddefer ensureReaderClosed(resp)pattern (matchingimage_inspect.go,image_history.go, etc.), proper API version guard viarequiresVersion, context propagation, and error handling throughout.image_attestations_opts.go: Clean functional-options pattern consistent with other option types in this package.client_interfaces.go: Interface addition matches the concrete implementation's signature exactly.attestation.go: New type file (not in diff but vendored correctly).vendor.mod/vendor.sum/vendor/modules.txt: Dependency bookkeeping updated consistently.
vvoland
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)