commands: print lint warnings after --call output - #4030
Open
locker95 wants to merge 1 commit into
Open
Conversation
--call outline writes to stdout while vertex warnings were dumped on stderr from the progress printer's OnClose, which races with that output. Keep warnings on stderr, but print them after the call result. Fixes docker#2973 Signed-off-by: Dean Chen <862469039@qq.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--call outlineprints on stdout while vertex warnings were dumped from the progress printer's OnClose on stderr, so they could overlap the outline.warnings still go to stderr, just after the call result.
Fixes #2973