docker-container: wait for buildkitd before Dial - #4023
Closed
locker95 wants to merge 1 commit into
Closed
Conversation
A new builder can be Running before buildkitd binds its socket. DriverHandle caches the first Client() error, so that race is sticky. Signed-off-by: Dean Chen <862469039@qq.com>
Member
|
Thanks, opened #4027 as alternative. We also need to handle cached client properly. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A freshly created docker-container builder can show Running before buildkitd has bound its socket. The first build then fails with "no such file" or a server-preface EOF, and DriverHandle caches that Client() error so we never recover.
Bootstrap already waits on
buildctl debug workersafter start. The Boot() fast path skips Bootstrap when the container is already Running, so Client() now does that same wait before Dial.Fixes #4021