Skip to content

feat: add recalculate_modeling_correction_factor to PVSystem #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javlor merged 2 commits into from
Jul 9, 2026
+7 −0
Merged

feat: add recalculate_modeling_correction_factor to PVSystem #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0cb460
feat: add recalculate_modeling_correction_factor to PVSystem
timvanbenthem-dnv Jul 8, 2026
7d47b8c
ruff format
timvanbenthem-dnv Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions solarfarmer/models/pvsystem/pvsystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,8 @@ class PVSystem:
AC ohmic loss (per unit) (default depends on inverter type).
module_mismatch: Optional[float] = None
Module mismatch loss (per unit) (default is 0.005).
recalculate_modeling_correction_factor: bool
Whether to recalculate the modeling correction factor (default is True).
module_quality_factor: Optional[float] = None
Module quality factor (per unit) (default is 0.0, i.e., no quality loss).
lid_loss: Optional[float] = None
Expand Down Expand Up @@ -269,6 +271,7 @@ class PVSystem:
dc_ohmic_loss: float | None = None # Default depends on inverter type
ac_ohmic_loss: float | None = None # Default depends on inverter type
module_mismatch: float | None = MODULE_MISMATCH_FACTOR
recalculate_modeling_correction_factor: bool = True
module_quality_factor: float | None = 0.0
lid_loss: float | None = None
module_iam_model_override: str | None = None
Expand Down Expand Up @@ -850,6 +853,9 @@ def describe(self, verbose=False) -> None:

# Modeling Options
print("\n--- MODELING OPTIONS ---")
print(
f"Recalculate Modeling Correction Factor: {self.recalculate_modeling_correction_factor}"
)
print(f"Enable Spectral Modeling: {self.enable_spectral_modeling}")
print(f"Module IAM Model Override: {self.module_iam_model_override}")
print(f"Calculate DHI (from GHI in weather file): {self.calculate_dhi_from_ghi}")
Expand Down Expand Up @@ -1543,6 +1549,7 @@ def generate_pan_file_supplements(

pan_file_supplements = {}
pan_file_supplements[module_info["pan_filename"]] = PanFileSupplements(
recalculate_modeling_correction_factor=plant.recalculate_modeling_correction_factor,
module_quality_factor=plant.module_quality_factor,
lid_loss=lid_loss,
bifaciality_factor=bifaciality_factor,
Expand Down
Loading