Point install URLs to dnsimple.com - #77
Merged
Merged
Conversation
dnsimple.com now serves install.sh and install.ps1. The Netlify site stops publishing the scripts and redirects the old URLs, so the upgrade command that older releases print keeps working.
weppos
added
the
enhancement
dnsimple.com serves the install scripts now, and holds the only copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The install URLs now point to
https://dnsimple.com/install.shandhttps://dnsimple.com/install.ps1. This change updates the upgrade command in the new release notice and the README. The Netlify site stops publishing the scripts and redirects the old install URLs to dnsimple.com, so the upgrade command that older releases print continues to work.This change deletes
install.shandinstall.ps1.dnsimple/dnsimple-appnow holds the only copy of the scripts, so a change to a script is made there.🔍 QA
Scenario: Upgrade command
go test ./internal/update/.📋 Deployment Pre/Post tasks
curl -sI https://dnsimple-cli.netlify.app/install.shreturns a 301 tohttps://dnsimple.com/install.sh.curl -sI https://cli-beta.dnsimple.com/install.ps1returns a 301 tohttps://dnsimple.com/install.ps1.curl -fsSL https://dnsimple-cli.netlify.app/install.sh | headreturns the shell script.