Migrate to CTK 13 as the default for Linux. - #97
Open
trivialfis wants to merge 3 commits into
Open
Conversation
trivialfis
temporarily deployed
to
containers-staging
July 30, 2026 03:51 — with
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
Updates the project’s CI/container toolchain in support of CUDA Toolkit 13 (CTK 13) usage on Linux by refreshing container build arguments and dependencies.
Changes:
- Bump Miniforge version across Linux container Dockerfiles to
26.3.2-3. - Update CUDA 13 CI build args to
13.3.0and bump NCCL version to2.30.7-1; align CUDA 13 NCCL package install to useCUDA_SHORT. - Adjust Linux CPU test conda environment dependencies (adds
libgrpc, reorganizes a few deps) and update clang-tidy container to LLVM/clang 21.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| containers/dockerfile/Dockerfile.manylinux_2_28_aarch64 | Miniforge version bump for manylinux aarch64 image. |
| containers/dockerfile/Dockerfile.jvm_gpu_build | Miniforge version bump for JVM GPU build image. |
| containers/dockerfile/Dockerfile.jvm | Miniforge version bump for JVM image. |
| containers/dockerfile/Dockerfile.gpu_build_rockylinux8 | Miniforge version bump; removes in-image gRPC build step. |
| containers/dockerfile/Dockerfile.gpu_build_r_rockylinux8 | Miniforge version bump for R GPU build image. |
| containers/dockerfile/Dockerfile.gpu_build_cuda13_rockylinux8 | Miniforge version bump; NCCL install now parameterized by CUDA_SHORT. |
| containers/dockerfile/Dockerfile.gpu | Miniforge version bump for GPU runtime/test image. |
| containers/dockerfile/Dockerfile.cpu | Miniforge version bump; removes in-image gRPC build step. |
| containers/dockerfile/Dockerfile.clang_tidy | Updates LLVM apt repo/packages and alternatives from clang-tidy 19 → 21. |
| containers/conda_env/linux_cpu_test.yml | Updates CPU test environment deps (adds libgrpc, reorganizes some packages). |
| containers/ci_container.yml | Bumps NCCL version; sets CUDA 13 build lane to CUDA 13.3.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
containers/extract_build_args.sh:8
- The example now uses
CUDA_VERSION, but other nearby docs/tools in this repo still mention*_ARG(e.g.CUDA_VERSION_ARG). Sinceextract_build_args.jqemits keys exactly as they appear underbuild_argsincontainers/ci_container.yml(and these match DockerfileARGnames), it would help to clarify in this example that there is no*_ARGsuffix to avoid confusion when copying/pasting.
## CONTAINER_DEF='clang_tidy' BUILD_ARGS='--build-arg CUDA_VERSION=13.3.0'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.