Skip to content

Migrate to CTK 13 as the default for Linux. - #97

Open
trivialfis wants to merge 3 commits into
dmlc:mainfrom
trivialfis:ctk-13
Open

Migrate to CTK 13 as the default for Linux.#97
trivialfis wants to merge 3 commits into
dmlc:mainfrom
trivialfis:ctk-13

Conversation

@trivialfis

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s CI/container toolchain in support of CUDA Toolkit 13 (CTK 13) usage on Linux by refreshing container build arguments and dependencies.

Changes:

  • Bump Miniforge version across Linux container Dockerfiles to 26.3.2-3.
  • Update CUDA 13 CI build args to 13.3.0 and bump NCCL version to 2.30.7-1; align CUDA 13 NCCL package install to use CUDA_SHORT.
  • Adjust Linux CPU test conda environment dependencies (adds libgrpc, reorganizes a few deps) and update clang-tidy container to LLVM/clang 21.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
containers/dockerfile/Dockerfile.manylinux_2_28_aarch64 Miniforge version bump for manylinux aarch64 image.
containers/dockerfile/Dockerfile.jvm_gpu_build Miniforge version bump for JVM GPU build image.
containers/dockerfile/Dockerfile.jvm Miniforge version bump for JVM image.
containers/dockerfile/Dockerfile.gpu_build_rockylinux8 Miniforge version bump; removes in-image gRPC build step.
containers/dockerfile/Dockerfile.gpu_build_r_rockylinux8 Miniforge version bump for R GPU build image.
containers/dockerfile/Dockerfile.gpu_build_cuda13_rockylinux8 Miniforge version bump; NCCL install now parameterized by CUDA_SHORT.
containers/dockerfile/Dockerfile.gpu Miniforge version bump for GPU runtime/test image.
containers/dockerfile/Dockerfile.cpu Miniforge version bump; removes in-image gRPC build step.
containers/dockerfile/Dockerfile.clang_tidy Updates LLVM apt repo/packages and alternatives from clang-tidy 19 → 21.
containers/conda_env/linux_cpu_test.yml Updates CPU test environment deps (adds libgrpc, reorganizes some packages).
containers/ci_container.yml Bumps NCCL version; sets CUDA 13 build lane to CUDA 13.3.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread containers/ci_container.yml

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

containers/extract_build_args.sh:8

  • The example now uses CUDA_VERSION, but other nearby docs/tools in this repo still mention *_ARG (e.g. CUDA_VERSION_ARG). Since extract_build_args.jq emits keys exactly as they appear under build_args in containers/ci_container.yml (and these match Dockerfile ARG names), it would help to clarify in this example that there is no *_ARG suffix to avoid confusion when copying/pasting.
##   CONTAINER_DEF='clang_tidy' BUILD_ARGS='--build-arg CUDA_VERSION=13.3.0'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants