std.regex: drop redundant bmatch run from the test suite - #11046
Conversation
DmitryOlshansky
left a comment
DmitryOlshansky
left a comment
There was a problem hiding this comment.
Since engines are picked from pattern it makes it truly important to run all engines in test suit. So just dropping bmatch is not a good solution, what is needed is a way to pick engine at least internally.
|
At first I thought, but since that pattern — explicitly forcing the backtracking engine — can't be reached through the public API, I wonder if it's worth it. |
|
It's not public but the engine better be tested even if currently it is not selected for the pattern. |
|
It wold seem to me the solution here is (potentially via a private API) to force the engine irrespective of the pattern, and then test all of the engines on whatever the set of patterns comprise the test suite. |
|
Okay, I'll add the internal helper later. |
|
Seems fine, go ahead and merge? |
match and bmatch are equivalent (both pick the engine from the pattern), so running run_tests!match() only.
b2562f5 to
a8bda93
Compare
|
Rebased. Needed due to CI changes. |
|
With regard to 3f18cfa: |
4 participants
Rationale
match and bmatch are equivalent (both pick the engine from the pattern), so running run_tests!match() only.
Pre-review checklist
[ ] If my PR fixes a bug or introduces a new feature, I have added thorough tests.[ ] If my changes are non-trivial and do not concern a reported issue, I have added a changelog entry.