Activity

1. dkackman

   added

   enhancementNew feature or requestNew feature or request

   owner:donParked for human decisionParked for human decision

   ideaAn idea for the researcher agent to assessAn idea for the researcher agent to assess

   backend:shared

   owner:leadFeature lead's turn (harnest R11)Feature lead's turn (harnest R11)

   priority:2Backlog rank: solid ROI, moderate scopeBacklog rank: solid ROI, moderate scope

   featureWork bigger than a fix: designed with Don, built in stages (harnest R11)Work bigger than a fix: designed with Don, built in stages (harnest R11)

   and removed

   owner:donParked for human decisionParked for human decision

   ideaAn idea for the researcher agent to assessAn idea for the researcher agent to assess

   on Oct 5, 2026
2. dkackman commented on Oct 5, 2026

   

   dkackman

   on Oct 5, 2026

   Last edited by dkackman

   OwnerAuthor

   More actions

   Approved by Don (2026-10-05) at priority:2, for the fit_to_model / restore_to_source pair only. The guided-enhancement-anchors extension is split out to #613 to be assessed on its own. The plan should also make upscale-clip and refine-clip handle aspect the same way. Handing to the feature lead for a plan.
3. dkackman commented on Oct 5, 2026

   

   dkackman

   on Oct 5, 2026

   Last edited by dkackman

   OwnerAuthor

   More actions

   Plan v4: fit_to_model / restore_to_source (#602)

   Plan by the lead agent, model claude-opus-5-5 via anthropic. Scope is the task pair only, plus making upscale-clip and refine-clip handle aspect ratio the same way, as Don's 2026-10-05 comment set it. The anchors extension is #613.

   Approved by Don (2026-10-05) as v1/v2; that approval was withdrawn when building stage B showed two parts of v2 don't hold against the code (#632's comment). v3 approved by Don (2026-10-06), with Q2′ as recommended. v4 records that decision (see Decisions); scope is unchanged from v3. Stage A (#631) is verified and stands; v3 adds two small changes to its tasks, built in stage B.

   Verdict: build smaller, in two stages

   What it gives. Today the caller has to set width/height to match the source clip. Both templates spend most of their descriptions on this, and the two get it wrong in opposite ways:

   • upscale-clip silently centre-crops a different aspect ratio. That's diffusers' preprocess_video(resize_mode="crop"), pipeline_ltx2_ic_lora.py:1424.
   • refine-clip silently stretches it (pipeline_ltx2_latent_upsample.py:363).
   • A short source is lapped from frame 0 in refine-clip (loop_frames). In upscale-clip it gets no reference past its end.

   With the pair, the size variables become the model's working size. Any source fits into that size and comes back at exactly its own size (×2 for these templates) and its own frame count.

   Value.

   • Who gains: Don's driving sessions that run v2v on footage dw didn't make.
   • Evidence is thin. In the last 200 jobs, every run of either template was in regression-model-specific. Neither is in any of Don's workspaces, there are no field reports, and the templates are two days old.
   • What it rests on: Don's priority:2 approval, and the fact that this is exactly the setting both descriptions warn about.
   • Prior rejection: idea: generalized video upscale/resize task #512 (a general resize_video task) was declined. This plan stays narrower than that. It is a model-bound round trip with a record, not a general resize task.

   Build cost. About $9–14: stage A $4–6 (spent, verified), stage B $5–8 (v3).

   Inertia.

   • Surface: two tasks in list_tasks/get_task, one mode domain in dw/task_domains.py, and a record shape that templates come to depend on.
   • No MCP tools or REST routes, and the SURFACE_BUDGET in tests/test_mcp_server.py doesn't count tasks.
   • Template variables: refine-clip's names are unchanged; their meaning narrows from "the source's size" to "the model's working size". upscale-clip's width/height keep their names and their meaning, the output size (Q2′), so no variable is removed.
   • No security boundary moves. Both tasks take in-memory frames, or a video reference through the existing loaders.

   Reversibility. Good while the only consumers are templates. The record shape is internal to a fit→restore pair inside one workflow, so it can change without a breaking-change until a user's saved workflow names its fields.

   Cheaper alternatives (considered; Don chose the full pair).

   1. Only make the two templates agree. Add a crop step to refine-clip so both crop. About $2; gets consistency, but not the exact size, the uncropped content, or the frame count back.
   2. Do nothing. The descriptions already tell the caller to match the source.

   Overlap.

   • idea: guided enhancement anchors - image-model-enhanced keyframes as LTX v2v conditions (split from #602) #613 (anchors) needs its keyframes in the fitted frame, so it builds on this.
   • idea: overlap windowing for long video sources (split, process, cosine-blend join) #601 (overlap windowing) is complementary: fit once, window, join, restore once.
   • idea: strength-selectable same-size LTX refine (sigma ladder) + per-segment strength decay in chains #606 (strength-selectable refine via a sigma ladder) is the model-native version of the issue's orig*(1-s)+out*s blend. That is why the blend is cut here.

   Cut, and what brings each part back:

   • The blend option. idea: strength-selectable same-size LTX refine (sigma ladder) + per-segment strength decay in chains #606 covers strength natively. It comes back if idea: strength-selectable same-size LTX refine (sigma ladder) + per-segment strength decay in chains #606 is declined, or if a field report asks for a weaker refine that idea: strength-selectable same-size LTX refine (sigma ladder) + per-segment strength decay in chains #606 can't give.
   • "Keep the original tail frames the model dropped". Splicing unprocessed frames after processed ones shows a visible seam, and with the frame handling below nothing is dropped below the source length. It comes back on a field report that wants a long source refined only in its head.
   • Adopting the pair in restore-deblur/restore-decompression. They have the same silent crop. A separate follow-up (Q3).

   Problem and non-goals

   Problem. v2v templates make the caller conform the footage, and the two 2x templates disagree on how they do it.

   Non-goals:

   • general-purpose resizing (idea: generalized video upscale/resize task #512 declined that);
   • deriving width/height/num_frames from the source at run time;
   • MCP or REST changes;
   • the anchors (idea: guided enhancement anchors - image-model-enhanced keyframes as LTX v2v conditions (split from #602) #613).

   The design

   The proposal is corrected below where the code disagreed with it.

   Task fit_to_model(video, width, height, num_frames, mode="letterbox", downscale=1)

   What it does:

   • Takes a video argument: an in-memory frame result, asset: or output:.
   • Resizes every frame into width×height using bicubic resampling with antialiasing. mode is one of:
     • stretch: resize to fill the frame exactly.
     • crop: scale to fill and centre-crop.
     • letterbox: scale to fit, then centre it on black.
   • Sets the frame count to exactly num_frames:
     • a longer source is cut to its first num_frames frames;
     • a shorter one is padded by holding its last frame, not by lapping to frame 0 as loop_frames does.
   • downscale (v3, built in stage B): an optional positive integer, default 1. It fits into width/downscale × height/downscale and records that as the model size.
     • It refuses, naming both values, when width or height isn't divisible by it.
     • Why: LTX2InContextPipeline takes width/height at the output size and derives its reference as width // reference_downscale_factor (pipeline_ltx2_ic_lora.py:1403-1404). Workflow JSON can't divide a variable, so the task does it. upscale-clip passes downscale: 2, matching its reference_downscale_factor: 2.

   What it returns: a dict, so later steps read it as previous_result:<step>.video and previous_result:<step>.fit (the precedent is outpaint.json's mask_image.bordered_image).

   • video: the frames, float [0,1], with the source's fps.
     • v3, built in stage B: it becomes a float32 numpy.ndarray subclass carrying .fps (in dw/media_types.py, alongside AudioVideo), instead of an AudioVideo.
     • Why: nothing in the engine unwraps an AudioVideo handed to a pipeline argument or a condition's frames, and previous_result:fit.video.frames doesn't resolve (get_artifact_properties, dw/result.py:217, reads one level). An ndarray passes diffusers' own isinstance(np.ndarray) checks as-is, and stays float, which LTX2ReferenceCondition needs (ltx2/reference-sheet: succeeds with no warnings but every frame is blocky mush; default asset:reference_sheet.png missing #444).
     • The contract stage A's cases test (video, float [0,1], source fps, saved like any video) doesn't change.
   • fit: the record:
     • mode;
     • source_width, source_height, source_frames;
     • model_width, model_height, model_frames;
     • content_box (x, y, w, h): where the source sits in the model frame. In crop mode, source_box is the part of the source that was kept.

   Correction to the proposal: it does not pick a bucket or a grid.

   • width, height and num_frames stay template variables that the task reads.
   • The reason: variable_constraints (dw/variable_constraints.py:267,362), cost_drivers and the VRAM estimate (dw/plan.py:318, dw/vram_estimate.py:57) only see variables. A size or frame count computed at run time would lose the 32n / 8n+1 refusals and the cost quote.
   • So "pad the frame count to the grid" means padding a short source up to the caller's 8n+1 num_frames. Restore then trims the padding back.
   • No snap: the existing 8n+1 refusal stays as it is.

   Refusals, before any work:

   • width/height/num_frames not positive integers;
   • unknown mode;
   • an empty video.

   Task restore_to_source(video, fit)

   What it does:

   • Scale: inferred as video.width / model_width. It must equal video.height / model_height, otherwise it refuses with both sizes named. So the 2x templates need no scale argument. This is a correction: the proposal assumed restore always goes back to 1×.
   • Size:
     • Letterbox: crops content_box × scale, then resizes to source_width × scale × source_height × scale.
     • Stretch: resizes straight to that size.
     • Crop: the cut edges don't exist in the output, so it returns the kept source_box at the source's pixel density (× scale). It is exact in density, smaller on the cropped axis, and the description says so.
   • Frames: trims to min(source_frames, frame count of video). Padding is removed. A pipeline that floored the count returns what it made, and the record says how many frames there should have been.
   • fps: passes through.
   • Refuses: a record missing fields or with the wrong types, and a mismatched scale.

   Audio

   • Neither task touches the soundtrack.
   • The templates already take it from the source (normalize_audio) and pair_audio(fit="video") cuts it to the video.
   • After restore, the video is the source's length, so the soundtrack now covers the whole output instead of being cut.

   Templates (stage B)

   Both get the same step sequence:

   1. fit (mode from a new fit variable, default letterbox, per Q1);
   2. the pipeline, fed previous_result:fit.video;
   3. restore (video: previous_result:<pipeline>, fit: previous_result:fit.fit);
   4. the existing pair_audio.

   Per template:

   • upscale-clip: fit to the IC reference size (pipeline_ltx2_ic_lora.py:1403), half the output. Diffusers' crop is then a no-op.
     • Q2′: width/height stay the output size (default 960×544, 32n), passed to the pipeline as today. fit gets width: variable:width, height: variable:height, downscale: 2, so the reference is 480×272. The reference is fed as previous_result:fit.video in place of variable:source_video.
     • cost_drivers and the VRAM estimate keep seeing the output size, as today.
     • v2's ref_width/ref_height (Q2) can't be wired: nothing could pass the pipeline 2 × ref_width. A cross-variable constraint would be an engine change, and reference_downscale_factor: 1 would give a 1× output from a 2× LoRA.
     • Cost: upscale-clip's size variables name the output, and refine-clip's name the working size. The descriptions say which.
   • refine-clip: fit to width × height. loop_frames is replaced, and the upsampler's stretch becomes a no-op.

   Changed behaviour, stated in both descriptions:

   • a different aspect ratio is now letterboxed and restored, not cropped or stretched;
   • a short source is held and trimmed back, not lapped or left without a reference;
   • the final output is exactly 2× the source and the source's length.

   intermediate/ keeps the raw model output in the model frame.

   Surfaces:

   • Engine: none changed.
   • Syntax: none.
   • MCP/REST: none.
   • Tasks: two new ones (stage A), plus fit_to_model's downscale argument and video type (stage B, v3).
   • Templates: a new fit variable on both. No variable is removed or renamed, so no breaking-change (Q2′).
   • Plugin: skills/ltx-2.5/SKILL.md text, so the plugin version is bumped.

   Stages

   Stage A: the two tasks (server)

   What it builds:

   • fit_to_model and restore_to_source in dw/tasks/ (video_utils.py or a new fit.py);
   • register_command entries with summaries and parameter descriptions;
   • the mode domain in dw/task_domains.py;
   • a docs/TASKS.md Video Processing row each, plus a short "round trip" paragraph.

   Unit tests:

   • a round trip per mode on synthetic frames: size, frame count, content box, and pixels within tolerance for letterbox and stretch at 1× and 2×;
   • each refusal;
   • discovery (tests/test_task_discovery.py, presence tests).

   Deploy: server restart. Estimate: $4–6.

   Acceptance intent (over MCP):

   • Discovery: list_tasks lists both, and get_task shows their arguments and mode's three values.

   • Letterbox round trip: with an uploaded 640×480, 50-frame, 24 fps clip, a utility workflow runs fit_to_model(width=512, height=288, num_frames=57, mode=letterbox).

     • The fitted video (saved) is 512×288 with 57 frames, with black bars at the sides.
     • Restoring it gives 640×480, 50 frames, 24 fps, with the bars gone (the frames match the source by eye in get_output_frames).

   • Scale inferred: the same round trip with a 2× resize in between (an existing per-frame resize_rescale step) restores to 1280×960.

   • Stretch: restores to 640×480.

   • Crop: restores to the kept region at source density. A 640×480 source into 512×288 gives 640×360.

   • Long source: a source longer than num_frames comes back at num_frames frames.

   • Refusals:

     • an unknown mode;
     • zero or negative sizes or frame counts;
     • a restore whose input size isn't a uniform multiple of the model size;
     • a malformed fit record.

     Each names the argument, and fails at its step without loading a pipeline.

   Stage B: rewire upscale-clip and refine-clip (server + plugin)

   Needs stage A.

   What it builds:

   • in dw/tasks/fit.py (v3):
     • fit_to_model's downscale argument, with its refusal and its get_task description;
     • its video as the fps-carrying float ndarray, so previous_result:fit.video feeds a pipeline argument or a condition's frames directly;
     • unit tests for both, including one that realizes previous_result:fit.video into a pipeline's arguments and a condition's frames through the real argument path, not a mock;
   • the step sequence above, in both templates;
   • the fit variable (default letterbox);
   • for upscale-clip, downscale: 2 on fit, with width/height unchanged;
   • rewritten descriptions and summaries, within the COMPACT_BUDGET in tests/test_catalog_structure.py:411;
   • workflows/templates/ltx2/README.md, plugins/dw/skills/ltx-2.5/SKILL.md (and a plugin version bump), docs/RECIPES_24GB.md:186.

   Tests to update: these pin today's shape.

   • tests/test_ltx2_ic_loras.py:
     • :212 unpacks two steps;
     • :174-185 pins the reference to variable:source_video. Only upscale-clip changes; the restore templates keep that pin;
     • :216 pins pair_audio's input.
   • tests/test_catalog_structure.py:566-645 (TestLtxRefineClip pins loop_frames).
   • The tests/test_step_cache.py:706-726 hashes, if the configuration changes.

   Deploy: server, plus a plugin release. Estimate: $5–8 (v3 adds the task changes).

   Acceptance intent (over MCP): two GPU runs, about 3 minutes each.

   • Both templates validate clean on a 640×480, 50-frame, 24 fps asset with a soundtrack, using defaults except source_video.
   • The final/ output is 1280×960, 50 frames, 24 fps, and its audio is the source's length.
     • The whole field of view survives: get_output_frames compared to the source shows no edge content lost.
     • The last frames are not frame 0 again.
     • There are no black bars.
   • intermediate/ shows the model-frame output with bars.
   • Source matching the working size: a source already at the working size gives the same output size as before this change.
   • downscale (v3): get_task fit_to_model shows it. A utility run with width=512, height=288, downscale=2 gives a 256×144 fitted video, and the record's model size is 256×144. downscale=3 with width=512 is refused, naming both.
   • Unchanged refusals:
     • size variables off 32n and num_frames off 8n+1 are still refused at validate;
     • a source with no soundtrack is still refused at source_audio, before any pipeline loads (refine-clip).
   • Edge halo (Q1): if the runs show a halo at the letterbox edge, the templates' default flips to stretch within this stage.

   Order and dependencies

   • A, then B. No other issue blocks either.
   • idea: guided enhancement anchors - image-model-enhanced keyframes as LTX v2v conditions (split from #602) #613 would build on A.

   Risks

   • The IC reference may not take in-memory frames. v2's fallback (save fit.video and reference the file) doesn't work: output: names only earlier runs, and an h264 round trip would lose detail before a 2× re-render. v3 makes fit.video an ndarray, the form refine-clip already feeds the upsampler, and stage B's unit test runs it through the real argument path first. If a condition's frames still won't take it, stage B stops and re-plans; it doesn't bend the engine.
   • The ndarray subclass may lose .fps through a numpy op that returns a plain array. Restore reads its fps from the pipeline output or the template's result.fps, as today. .fps only matters for saving fit.video itself, which stage B's tests pin.
   • Letterbox bars inside a generative re-render. The IC-LoRA may invent content in the bars, or soften the content edge. Restore crops the bars, but an edge halo is possible. If B's runs show one, the default flips to stretch (Q1).
   • Double resampling (fit, then restore) costs a little sharpness on a 1× round trip. For these 2× templates it is outweighed by the 2× resize.

   Follow-ups (filed to Don after stage B)

   • After stage B's GPU runs confirm letterbox holds up under a generative model, file adopting the pair in restore-deblur and restore-decompression (Q3).
   • If stage B leaves loop_frames with no template consumer, file its removal as a proposal.

   Decisions (Don)

   • Q1. Default mode (2026-10-05): letterbox for both templates. Flip to stretch if stage B's runs show an edge halo.
   • Q2. upscale-clip's size variables (2026-10-05): move to ref_width/ref_height with the output at 2×, removing width/height. Labelled breaking-change. Superseded by Q2′: it can't be wired (see Templates).
   • Q2′. upscale-clip's size variables (2026-10-06): as recommended. upscale-clip keeps width/height as the output size, and fit_to_model gains downscale (upscale-clip passes 2). No engine change, no breaking-change. The two templates' size variables mean different things (output vs working size), and the descriptions say which. fit.video as the fps-carrying float32 ndarray is approved.
   • Q3. restore-deblur / restore-decompression (2026-10-05): a separate follow-up, not in this plan.
4. dkackman

   added

   owner:donParked for human decisionParked for human decision

   status:plan-reviewA feature plan is posted and waiting for DonA feature plan is posted and waiting for Don

   and removed

   owner:leadFeature lead's turn (harnest R11)Feature lead's turn (harnest R11)

   on Oct 5, 2026
5. dkackman commented on Oct 5, 2026

   

   dkackman

   on Oct 5, 2026

   OwnerAuthor

   More actions

   Plan v1 approved by Don (2026-10-05).

   Q1-Q3 defaults accepted:

   • Q1: letterbox is the default mode. Flip it to stretch if stage B's runs show an edge halo.
   • Q2: upscale-clip moves to ref_width/ref_height, with the output at 2x. This is labelled breaking-change.
   • Q3: restore-deblur/restore-decompression become a separate follow-up.

   Follow-ups: after stage B's GPU runs confirm letterbox holds up under a generative model, file the Q3 issue. If stage B leaves loop_frames with no template consumer, file its removal as a proposal too. Both go to Don.
6. 29 remaining items

   Load more
7. dkackman

   added

   status:needs-specTester writes acceptance cases for the plan's stagesTester writes acceptance cases for the plan's stages

   on Oct 6, 2026
8. dkackman commented on Oct 6, 2026

   

   dkackman

   on Oct 6, 2026

   Last edited by dkackman

   OwnerAuthor

   More actions

   Spec for plan v4, revised for reshaped stage B (#632). Written from the plan alone by claude-opus-5-5 via anthropic. Every new case carries pending: #632.

   #631, stage A: unchanged. C-F237–C-F244 and SE-F043 stand.

   #632, stage B (reshaped), all in regression-suite-complete.md:

   • C-F318, replacing C-F245. It checks the template shape and the fit variable. upscale-clip keeps width/height (960×544, 32n) with no ref_*, and its fit step has downscale: 2. Each pipeline input reads fit.video directly. The 32n/8n+1 refusals hold at validate, and #602 stage B: rewire upscale-clip and refine-clip through fit/restore #632 has no breaking-change. Free.
   • C-F319, new: downscale on CPU.
     • get_task shows it (optional, default 1).
     • w=512, h=288, downscale=2 gives a 256×144 fit, with model size 256×144 in the record and content_box {32,0,192,144}.
     • Omitting it or passing 1 matches C-F238.
     • A 2× upscale in between restores to 1280×960.
     • downscale=32 gives 16×9.
     • fitted keeps 24 fps, which is the ndarray video keeping stage A's contract.
   • C-F320, new: downscale refusals.
     • downscale=3, width=512 names both.
     • The height-only arm is downscale=5, 515×288.
     • 0, -2, 1.5 and "two" are refused.
     • No silent floor, and nothing loads.
   • C-F321, replacing C-F248: a source already at the working size gives the same output size. upscale-clip runs with width 1024 / height 576 on the 512×288×121 fixture. GPU.
   • C-F322, replacing C-F250: the descriptions, summaries and skill describe fit/restore. Each says which size its variables name (output for upscale-clip, working for refine-clip). No ref_* text, and nothing called breaking.
   • C-F246, C-F247 and C-F249 stand. They hold under v4: upscale-clip's defaults of 960×544 fit to 480×272, which restores at 2× to 1280×960.

   The superseded C-F245, C-F248 and C-F250 can't be edited from here. dkackman/harnest#60 asks to retire them. Until it is applied, a post-verify regression run would fail them on purpose-changed behaviour.

   Notes (non-blocking):

   • The plan names the unit test that realizes previous_result:fit.video into a condition's frames. Over MCP that is covered only through C-F246/C-F247's GPU runs, since neither template exposes a condition the tester can feed separately.
   • The ndarray subclass dropping .fps (a risk the plan names) would show as fitted losing 24 fps in C-F319 and C-F238.
9. dkackman

   added

   owner:leadFeature lead's turn (harnest R11)Feature lead's turn (harnest R11)

   and removed

   owner:testerTester's turn to actTester's turn to act

   status:needs-specTester writes acceptance cases for the plan's stagesTester writes acceptance cases for the plan's stages

   on Oct 6, 2026
10. dkackman

    added a commit that references this issue on Oct 6, 2026

    Merge branch 'docs/602-closeout-fit-to-model' into develop (#602)

    14663be
11. dkackman commented on Oct 6, 2026

    

    dkackman

    on Oct 6, 2026

    OwnerAuthor

    More actions

    Close-out: both stages closed and verified. #631 (stage A, the fit_to_model / restore_to_source tasks) and #632 (stage B, upscale-clip and refine-clip rewired through fit/restore, plus downscale and the FittedVideo ndarray) both verified 2026-10-06. Q1's letterbox default stands: C-F246 showed no edge halo.

    Design record: docs/proposals/complete/fit-to-model-restore-complete.md (develop @ 14663be, commit ef7c25c). It covers what was built, bounces per stage (one each), and what was deferred: Q3 (the pair in restore-deblur/decompression), the blend and tail-splice cuts, and #613. todo.md has the shipped entry, and the two ltx2 clip records note the crop/stretch rule they describe is superseded. loop_frames keeps a consumer (reference-sheet.json), so no removal follow-up.

    verify: run every case whose source: names one of this feature's stages, and close the parent if they all pass. C-F245, C-F248 and C-F250 are plan-v2 cases whose retirement is requested in dkackman/harnest#60/#65; they are not expected to pass.

    — lead agent, claude-opus-5-5 via anthropic
12. dkackman

    added

    owner:testerTester's turn to actTester's turn to act

    status:fixed-pending-verifyImplementer fixed, awaiting tester verificationImplementer fixed, awaiting tester verification

    and removed

    owner:leadFeature lead's turn (harnest R11)Feature lead's turn (harnest R11)

    on Oct 6, 2026
13. dkackman commented on Oct 6, 2026

    

    dkackman

    on Oct 6, 2026

    OwnerAuthor

    More actions

    Verified: feature parent #602. Tester, running as claude-opus-5-5 via anthropic, against lem on develop @ 14663be, in workspace regression-complete.

    I ran every case whose source: names #631 or #632. All passed. I did not run or count C-F245, C-F248 or C-F250, which are superseded plan-v2 cases with retirement requested in harnest#60/#65.

    Templates (GPU)

    • C-F246, upscale-clip on the 640×480×50 source:
      • final/ is 1280×960×50 at 24 fps, with 2.083 s of audio.
      • Frames 0 and 49 show the full field of view with no bars.
      • intermediate/ is 960×544×121 and shows real side bars.
      • get_workflow shows downscale 2, reference_downscale_factor 2, reference frames taken from previous_result:fit.video, and no ref_*.
    • C-F247, refine-clip on the same source:
      • final/ is 1280×960×50 at 24 fps, with 2.083 s of audio.
      • Frame 49 is not lapped.
      • intermediate/ is 1024×576×121 with side bars, and frames 49 to 120 hold the last frame.
    • C-F321: I ran refine-clip with src-512x288-121f, and upscale-clip with the same source at 1024×576×121.
      • Both final/ outputs are 1024×576×121 at 24 fps, with 5.042 s of audio.
      • Both intermediates are 1024×576×121, and frame 60 shows no bars.
    • C-F249: refine-clip on src-640x480-50f-silent.mp4 failed in 1.2 s at step 0, source_audio, with the error "...carries no audio track...". No pipeline phase was reached.

    Tasks (round trip)

    • C-F238, C-F239, C-F240, C-F241, C-F242, C-F319: I ran the letterbox, crop, stretch and ds2/ds32 variants, the 512×512, 320×240 and n=50 sources, and the long source (124 frames cut to 57).
      • Every fit record had the expected content_box/source_box and model/source sizes.
      • Every restore came back at the source size, or at exactly 2× it after an upscale to 1024×576.
      • Every restore came back at the source frame count, or the trimmed count for the long source.
      • Every output was 24 fps.
    • C-F243 and C-F320: each bad mode/width/height/num_frames/downscale arm was refused at validate, with its path and value named. That covers the 3-mode list, "above zero", "whole number", "to be a number", and the divisible-by-downscale message.
    • C-F244: each arm failed at restore, naming fit and the field:
      1. The wrong-size video got "a uniform multiple of the fitted size ... 1024x288 ... 512x288".
      2. source_width None got "not a whole number above zero".
      3. model_width 'abc' got "'abc', not a whole number above zero".
      4. mode 'zoom' got "its 'mode' is 'zoom'".
      5. fit set to previous_result:fit.video got "got a FittedVideo".
    • C-F318: both templates refused width 500, height 300, num_frames 50 and fit "zoom" at validate. The errors were at arguments.width, arguments.height and arguments.num_frames, plus fit_to_model needs 'mode' as one of [...]. #602 stage B: rewire upscale-clip and refine-clip through fit/restore #632 carries no breaking-change label.
    • C-F322:
      • The list_workflows summaries read "width/height = the working size" for refine-clip and "= the render size" for upscale-clip.
      • get_workflow describes the default letterbox and the stretch/crop options, and says a short source is held and a long one cut.
      • Both say the output is exactly 2× the source, and neither mentions ref_* or calls the change breaking.
      • The dw:ltx-2-5 skill says the same.
    • C-F237: I checked get_task's text for both tasks earlier in this session.

    Security

    • SE-F043: fit.video (set through src) and a literal restore.video were both tried with /etc/passwd, /nonexistent-dw-probe/x.mp4 and ../../../../etc/passwd, and src was also set to file:///etc/passwd.
      • Every probe returned valid: false at that step's arguments.video.
      • The existing and nonexistent paths got identical SE-F014 wording.
      • The .. and file: probes got their own refusals, and no message echoed anything beyond the string sent.
      • The control asset validated clean.
      • run_workflow(acknowledged_cost=true) on the /etc/passwd arm raised the same refusal and queued no job.

    Cleanup: I deleted all 12 runs this session made with delete_output(job_id=...).
14. dkackman

    added

    status:verifiedTester confirmed the fix via a real MCP callTester confirmed the fix via a real MCP call

    and removed

    status:fixed-pending-verifyImplementer fixed, awaiting tester verificationImplementer fixed, awaiting tester verification

    on Oct 6, 2026
15. dkackman

    closed this as completedon Oct 6, 2026
16. nikhilash6

    added a commit that references this issue on Oct 10, 2026

    docs(proposals): dkackman#602 close-out - design record for fit_to_mo…

    ...

    ef7c25c