Skip to content

refactor: improve versionInjector and error handling in esbuild plugin #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gorniaky merged 1 commit into from
Aug 8, 2026
Merged

refactor: improve versionInjector and error handling in esbuild plugin #936

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 22 additions & 7 deletions esbuild.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,15 @@ import { context } from "esbuild";
import { readFileSync } from "fs";
import Replace from "unplugin-replace/esbuild";

export function versionInjector() {
function versionInjector() {
/** @type {import("type-fest").PackageJson} */
let pkg;
return Replace({
include: [/\.(js|ts)$/],
values: [{
find: "__PACKAGE_VERSION__",
replacement() {
/** @type {import("type-fest").PackageJson} */
const pkg = JSON.parse(readFileSync("./package.json", "utf8"));
pkg ??= JSON.parse(readFileSync("./package.json", "utf8"));
return pkg.version;
},
}],
Expand All @@ -24,12 +25,26 @@ const esbuildProblemMatcherPlugin = {
build.onStart(() => console.log("[watch] build started"));

build.onEnd((result) => {
for (let i = 0; i < result.errors.length; i++) {
const error = result.errors[i];
if (result.warnings.length) {
const messages = [], params = [];

console.error("✘ [ERROR] %s", error.text);
for (const m of result.warnings) {
messages.push("⚠ [WARN] %s\n %s:%s:%s:");
params.push(m.text, m.location.file, m.location.line, m.location.column);
}

console.error(" %s:%s:%s:", error.location.file, error.location.line, error.location.column);
console.warn(messages.join("\n\n"), ...params);
}

if (result.errors.length) {
const messages = [], params = [];

for (const m of result.errors) {
messages.push("✘ [ERROR] %s\n %s:%s:%s:");
params.push(m.text, m.location.file, m.location.line, m.location.column);
}

console.error(messages.join("\n\n"), ...params);
}

console.log("[watch] build finished");
Expand Down
Loading