Repository navigation
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentvouch skill list --pagepreviously usedparseInt, silently changing malformed user input:9.5became page 9 and3xbecame page 3. The CLI now accepts only whitespace-padded positive decimal integers that fit in JavaScript's safe integer range; fractional, partially numeric, signed, scientific-notation, and unsafe integer values produce the existing clear validation error.This is a focused CLI input-boundary fix: two files, no API, protocol, chain, dependency, or configuration changes.
Test plan
npm test --workspace @agentvouch/cli -- cli-options.test.tsfailed before the implementation because9.5was silently accepted as page 9.npm test --workspace @agentvouch/cli -- cli-options.test.ts— 10 tests passed.npm run test --workspace @agentvouch/cli— 13 files / 77 tests passed.npm run typecheck --workspace @agentvouch/cli— passed.npm run build --workspace @agentvouch/cli— passed (tsup ESM + declarations).npm run format:check— passed.npm run lint— passed.git diff --check origin/main...HEAD— passed.Rollback
Revert this commit to restore the prior permissive
parseIntbehavior; no data or deployed state requires cleanup.Not verified