Repository navigation
fix(web): reject non-string connected repo branches - #227
Merged
Merged
Conversation
dirtybits
changed the base branch from
fix/reject-unsafe-connected-repo-branches
to
main
October 11, 2026 06:05
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
branchas untrusted runtime input invalidateRepoCoords: preserve the existingundefined/nulldefault tomain, trim strings, and reject numbers, arrays, and objects with the existingInvalid branchresult.branch: {}(or another non-string JSON value) from reaching.trim()and returning a server error before repository ownership checks.No database schema, repository sync behavior for valid inputs, chain, wallet, payment, or deployment configuration changes.
Verification
npm test --workspace @agentvouch/web -- __tests__/lib/mirror-connectedRepos.test.ts --maxWorkers=1 --no-fileParallelism— passed (26 tests).npm run format:check— passed.npm run lint:web— passed.npm run typecheck— passed.npm test --workspace @agentvouch/web -- --maxWorkers=1 --no-fileParallelism— passed (141 files, 1,195 tests).git diff --check origin/fix/reject-unsafe-connected-repo-branches...HEAD— passed.npm exec --workspace @agentvouch/web -- next build --webpack— webpack compilation and TypeScript passed, but static prerendering stopped at/sitemap.xmlbecause this cron checkout lacksweb/.env.local/DATABASE_URL. The pre-existingoxdynamic-dependency warning was also emitted. No full production-build success is claimed.Rollback
Revert commit
029538b. This restores the prior behavior only; no schema, deployment, or persisted state requires rollback.