Repository navigation
Execute frozen research workflows with durable step journals - #357
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c5810ed15b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const delivery=await this.reports.report({id:`research:${run.id}`,jobId:agent.id,title:`${agent.title}: daily research digest`.slice(0,180),detail:research.report,recipient:config.recipient}); | ||
| const delivery=await this.reports.report({id:deliveryId,jobId:agent.id,title:`${agent.title}: daily research digest`.slice(0,180),detail:inputs?.report??research.report!,recipient:inputs?.recipient.recipient??config.recipient}); | ||
| research.delivery=delivery; | ||
| if(research.execution)recordStep(research,'deliver',delivery.status==='uncertain'?'uncertain':delivery.status==='failed'?'failed':'succeeded',{kind:'handoff',attempt,observation:delivery.status}); |
There was a problem hiding this comment.
When the report bridge returns status: "cancelled"—for example, after the recipient is removed while a report is pending—this branch records the handoff as succeeded, even though the delivery step and final outcome subsequently fail. Because the journal is exposed as durable audit evidence and StepRecord already supports cancelled, map this response to cancelled rather than presenting a cancelled handoff as successful.
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32f688a283
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const attempt=(research.execution?.handoffAttempts??research.deliveryAttempts??0)+1; | ||
| if(research.execution){ | ||
| if(attempt>Number(settings!.maxHandoffAttempts)){research.delivery={status:'uncertain',error:'The bounded handoff attempts were exhausted; check the existing delivery identity.'};await this.saveRun(run);return;} | ||
| research.execution.handoffAttempts=attempt;recordStep(research,'deliver','started',{kind:'handoff',attempt});await this.saveRun(run); |
There was a problem hiding this comment.
For executable v2 runs, this stores every handoff attempt in research.execution.handoffAttempts, but researchStepEvidence() in console/src/workflow-inspector.ts still displays only research.deliveryAttempts || 0. Because deliveryAttempts is normally untouched when the bridge returns a status, accepted deliveries and even five pending responses are presented as having zero handoff attempts, making the new evidence inspector contradict the durable journal. Use the execution counter for v2 runs, with the legacy field as a fallback.
Useful? React with 👍 / 👎.
|
Delivery verification complete: merged commit 15f8549 is on remote main; checkout and annotated v0.48.0-rc.1 tag match it. Release workflow 37800590424 succeeded and published the wheel and source distribution. The downloaded published wheel installed in a fresh environment; version and CLI smoke checks passed. Production deployment 37800488449 succeeded, including readiness, console Worker and public demo (not skipped). Required PR checks passed. Separate automatic Dependency Graph run 37800501618 failed before starting any job steps, emitted no diagnostics/findings, and GitHub rejected a rerun. Production npm audit reported zero vulnerabilities and scoped manual trust-boundary review completed; no dependencies changed. This separate scan limitation remains disclosed. |
1 participant
Summary
Closes #356.
Acceptance evidence
npm ci --offline, 340 passing tests, operator/demo bundle dry runs.Review and security
git diff --checkpassed. Production dependency audit reports zero vulnerabilities; no dependencies changed. Scoped manual review covered credential retention/redaction, untrusted provider/model text, safe DOM text rendering, tenant/role boundaries, endpoint/tool allowlists, frozen authority, pre-I/O persistence and replay/uncertainty behavior. Existing automated security-boundary tests passed. Fixtures are synthetic, not live-account execution or independent verification.Release / compatibility
Significant functionality; minor RC 0.48.0rc1 / v0.48.0-rc.1 because execution/evidence schemas change. Version metadata, dated changelog and compatibility notes are included. No destructive migration, arbitrary scripts, editable user graphs, new connectors or expanded authority. Legacy descriptive/absent contracts retain compatibility execution and no invented step journals. Owners save/capture a new executable snapshot, complete a fresh trial and reactivate. Historical definitions remain frozen.
Journals reference bounded normalized projections, not original provider payloads or private model reasoning. They are runtime-recorded, not signed/tamper-proof independent audits. Existing 40-run retention applies; explanations retain at most 250 characters / 400 JSON UTF-8 bytes. Transport remains at-least-once, and provider acceptance does not prove inbox receipt. The release tag, published artifacts, clean published-wheel installation and hosted deployment will be verified after merge.