fix: publish RamTier failure before completion - #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Final-main CI run 33398128478 exposed a real completion-order race in
RamTier.InflightDuplicateSharesTerminalLeaderFailure: bothPutCommittedwaiters could returnkIOErrorbefore the terminal flush path publishedhealthy=falseand dropped the failed entry.The failed assertion observed
rt.healthy()==trueafter both waiters joined.Fix
Capture the shared completion, publish all terminal side effects under the shard lock, then wake leader/follower waiters with
CompletePut(false).This preserves the contract that a completed terminal failure is fully visible when
PutCommittedreturns.Verification
ram_tier_test: 36/36 passed--gtest_break_on_failure: 100/100 passed