Skip to content

Reset the audio converter before raising a codec error #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romansorochak wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Reset the audio converter before raising a codec error #142

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
281dbf5
Reset the audio converter before raising a codec error
romansorochak Oct 13, 2026
cf6ee78
Shorten the raiseCodecError doc comment to the file's style
romansorochak Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions AudioStreaming/Streaming/AudioPlayer/Processors/AudioFileStreamProcessor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,7 @@ final class AudioFileStreamProcessor {
fillUsedFrames(framesCount: framesAdded)
return
} else if status != 0 {
fileStreamCallback?(.raiseError(.codecError))
raiseCodecError(resetting: converter)
return
}

Expand Down Expand Up @@ -620,7 +620,7 @@ final class AudioFileStreamProcessor {
fillUsedFrames(framesCount: framesAdded)
continue packetProcess
} else if status != 0 {
fileStreamCallback?(.raiseError(.codecError))
raiseCodecError(resetting: converter)
return
}
} else {
Expand Down Expand Up @@ -651,13 +651,24 @@ final class AudioFileStreamProcessor {
fillUsedFrames(framesCount: framesAdded)
continue packetProcess
} else if status != 0 {
fileStreamCallback?(.raiseError(.codecError))
raiseCodecError(resetting: converter)
return
}
}
}
}

/// Resets the converter and raises `.codecError`.
///
/// A failed fill can leave the converter holding a span of `inInputData`, which is freed once the
/// packets proc returns; resetting drops it, as `processSeek()` does.
///
/// - parameter converter: The `AudioConverterRef` that failed.
private func raiseCodecError(resetting converter: AudioConverterRef) {
AudioConverterReset(converter)
fileStreamCallback?(.raiseError(.codecError))
}

/// Fills the `AudioBuffer` with data as required
///
/// - parameter list: An `UnsafeMutableAudioBufferListPointer` object representing the buffer list be filled with data
Expand Down
Loading