Fix CVE-2025-59717 allow-list type confusion - #152
Open
thesmartshadow wants to merge 1 commit into
Open
thesmartshadow wants to merge 1 commit into
thesmartshadow wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes CVE-2025-59717 by normalizing the
allowedClassesandallowedEnvironmentsoptions before performing allow-list membership checks.Both options are intended to behave as allow-lists. However,
.includes()has different behavior depending on the value type: arrays perform exact membership checks, while strings perform substring checks.That means partial values such as
incould matchadmin,info, andprocould matchproduction,test, even though neither value was explicitly allowed.Changes
allowedClassesvalues into a single exact allowed valueallowedEnvironmentsvalues into a single exact allowed valueTesting
Tested locally with:
npm run lint:js npm test