Repository navigation
Mark __Host- cookie deletions as Secure so https sign-out works - #71
Merged
Merged
Conversation
On https the session and return-to cookies carry the __Host- prefix. That prefix requires the Secure attribute, so a deletion without it fails. Hono refuses to write the header, which crashed logout and any callback that failed the state check. Browsers would also ignore such a deletion and leave the cookie in place. Pass the same secure flag used when the cookies are set. Tests now run the auth routes against an https origin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On https the session and return-to cookies carry the __Host- prefix. That prefix requires the Secure attribute, so a deletion without it fails. Hono refuses to write the header, which crashed logout and any callback that failed the state check. Browsers would also ignore such a deletion and leave the cookie in place.
Pass the same secure flag used when the cookies are set. Tests now run the auth routes against an https origin.